Re: RFR: 8075810: LogManager.readConfiguration may throw undocumented IllegalArgumentException

2015-03-27 Thread Roger Riggs
...@oracle.com To: lance.ander...@oracle.com Subject: Re: RFR: 8075810: LogManager.readConfiguration may throw undocumented IllegalArgumentException CC: core-libs-dev@openjdk.java.net Hi Lance, Thanks for the review! On 24/03/15 16:01, Lance Andersen wrote: Hi Daniel, This looks OK but I might

RE: RFR: 8075810: LogManager.readConfiguration may throw undocumented IllegalArgumentException

2015-03-27 Thread Jason Mehrens
16:06:47 +0100 From: daniel.fu...@oracle.com To: lance.ander...@oracle.com Subject: Re: RFR: 8075810: LogManager.readConfiguration may throw undocumented IllegalArgumentException CC: core-libs-dev@openjdk.java.net Hi Lance, Thanks for the review! On 24/03/15 16:01, Lance Andersen wrote

Re: RFR: 8075810: LogManager.readConfiguration may throw undocumented IllegalArgumentException

2015-03-27 Thread Lance Andersen
that the tab is here. best regards, -- daniel Jason Date: Tue, 24 Mar 2015 16:06:47 +0100 From: daniel.fu...@oracle.com To: lance.ander...@oracle.com Subject: Re: RFR: 8075810: LogManager.readConfiguration may throw undocumented

Re: RFR: 8075810: LogManager.readConfiguration may throw undocumented IllegalArgumentException

2015-03-27 Thread Daniel Fuchs
: LogManager.readConfiguration may throw undocumented IllegalArgumentException CC: core-libs-dev@openjdk.java.net Hi Lance, Thanks for the review! On 24/03/15 16:01, Lance Andersen wrote: Hi Daniel, This looks OK but I might suggest clarifying that the cause could be set in the javadoc. Now that being said, I

Re: RFR: 8075810: LogManager.readConfiguration may throw undocumented IllegalArgumentException

2015-03-25 Thread Daniel Fuchs
From: daniel.fu...@oracle.com To: lance.ander...@oracle.com Subject: Re: RFR: 8075810: LogManager.readConfiguration may throw undocumented IllegalArgumentException CC: core-libs-dev@openjdk.java.net Hi Lance, Thanks for the review! On 24/03/15 16:01, Lance Andersen wrote: Hi Daniel, This looks

Re: RFR: 8075810: LogManager.readConfiguration may throw undocumented IllegalArgumentException

2015-03-24 Thread Lance Andersen
Hi Daniel, This looks OK but I might suggest clarifying that the cause could be set in the javadoc. Now that being said, I am not sure how consistent we are across the JDK or just make the assumption people will check the cause if they desire. As far as backporting, unless it really needed, I

Re: RFR: 8075810: LogManager.readConfiguration may throw undocumented IllegalArgumentException

2015-03-24 Thread Daniel Fuchs
Hi Lance, Thanks for the review! On 24/03/15 16:01, Lance Andersen wrote: Hi Daniel, This looks OK but I might suggest clarifying that the cause could be set in the javadoc. Now that being said, I am not sure how consistent we are across the JDK or just make the assumption people will check

RE: RFR: 8075810: LogManager.readConfiguration may throw undocumented IllegalArgumentException

2015-03-24 Thread Jason Mehrens
keyword and missing a tab ahead of 'props.load' Jason Date: Tue, 24 Mar 2015 16:06:47 +0100 From: daniel.fu...@oracle.com To: lance.ander...@oracle.com Subject: Re: RFR: 8075810: LogManager.readConfiguration may throw undocumented

Re: RFR: 8075810: LogManager.readConfiguration may throw undocumented IllegalArgumentException

2015-03-24 Thread Mandy Chung
On 3/24/2015 7:42 AM, Daniel Fuchs wrote: Hi, Please find below a fix for 8075810: LogManager.readConfiguration may throw undocumented IllegalArgumentException https://bugs.openjdk.java.net/browse/JDK-8075810 The proposed fix is to catch the IllegalArgumentException and wrap it in