Hi Erik,
I think this looks good.
Thanks
Markus
-Original Message-
From: Erik Gahlin
Sent: den 24 juni 2018 21:16
To: Alan Bateman ; hotspot-jfr-...@openjdk.java.net;
core-libs-dev
Subject: Re: RFR: 8203629: Produce events in the JDK without a dependency on
jdk.jfr
On 2018-06-24 19
On 2018-06-24 19:00, Alan Bateman wrote:
On 24/06/2018 12:42, Erik Gahlin wrote:
I have updated jdk.internal.event.Event class with comments.
http://cr.openjdk.java.net/~egahlin/8203629.2/
It is basically a copy the comments in jdk.jfr.Event, but without
reference to classes in the JFR module
On 24/06/2018 12:42, Erik Gahlin wrote:
I have updated jdk.internal.event.Event class with comments.
http://cr.openjdk.java.net/~egahlin/8203629.2/
It is basically a copy the comments in jdk.jfr.Event, but without
reference to classes in the JFR module.
The rationale for using a class instea
On 2018-06-21 09:52, Alan Bateman wrote:
On 20/06/2018 18:59, Erik Gahlin wrote:
:
Also all the methods are empty which makes me wonder if they should
be abstract (as the class is abstract) or whether it should be an
interface.
Abstract is needed to prevent user from instantiating the class.
ion say.
Hope this clarifies a bit
Thanks
Markus
[1] https://docs.oracle.com/javase/9/docs/api/jdk/jfr/Event.html
-Original Message-
From: Alan Bateman
Sent: den 21 juni 2018 09:52
To: Erik Gahlin ; hotspot-jfr-...@openjdk.java.net;
core-libs-dev
Subject: Re: RFR: 8203629: Produce
On 20/06/2018 18:59, Erik Gahlin wrote:
:
Also all the methods are empty which makes me wonder if they should
be abstract (as the class is abstract) or whether it should be an
interface.
Abstract is needed to prevent user from instantiating the class.
The methods need to have a body, otherwi
Sounds good Sean.
We will push this RFE when your enhancement is ready and reviewed. We
like to avoid pushing this to JDK 11 unless it is being used in "the
current train".
Erik
Thanks for implementing this enhancement Erik. I think it'll prove to
be popular given the functionality availabl
On 2018-06-20 19:09, Alan Bateman wrote:
On 19/06/2018 03:06, Erik Gahlin wrote:
Hi,
Could I have a review of an enhancement that will make it possible to
add JFR events to java.base, and possibly other modules in the JDK,
without a compile time dependency on jdk.jfr.
Bug:
https://bugs.op
Thanks for implementing this enhancement Erik. I think it'll prove to be
popular given the functionality available in JFR recordings. I'd agree
with Alan's comment that the Event class could be documented better to
indicate its purpose.
I'm already using this enhancement to implement some new
On 19/06/2018 03:06, Erik Gahlin wrote:
Hi,
Could I have a review of an enhancement that will make it possible to
add JFR events to java.base, and possibly other modules in the JDK,
without a compile time dependency on jdk.jfr.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8203629
Webrev
Hi Erik,
looks good.
Very powerful with minimal intrusion.
Thanks
Markus
-Original Message-
From: Erik Gahlin
Sent: den 19 juni 2018 04:07
To: hotspot-jfr-...@openjdk.java.net; core-libs-dev
Subject: RFR: 8203629: Produce events in the JDK without a dependency on jdk.jfr
Hi,
Could
11 matches
Mail list logo
