Re: RFR: 8234525: enable link-time section-gc for linux s390x to remove unused code

2019-11-26 Thread Erik Joelsson
On 2019-11-26 04:53, Baesken, Matthias wrote: Erik, may I add you as a reviewer too ? Yes. /Erik

RE: RFR: 8234525: enable link-time section-gc for linux s390x to remove unused code

2019-11-26 Thread Baesken, Matthias
Hi Martin , > Hi Matthias and Erik, > > I also think this is an interesting option. > > I like the idea to generate smaller libraries. In addition to that, I could > also > imagine building with -Os (size optimized) by default and only select -O3 for > performance critical files (e.g. C2's

RE: RFR: 8234525: enable link-time section-gc for linux s390x to remove unused code

2019-11-26 Thread Doerr, Martin
mber 2019 16:01 > To: Erik Joelsson ; 'build-...@openjdk.java.net' > ; core-libs-dev@openjdk.java.net > Subject: RE: RFR: 8234525: enable link-time section-gc for linux > s390x to remove unused code > > Hi Erik, >yes it makes the build more chatty - > our linux s390

RE: RFR: 8234525: enable link-time section-gc for linux s390x to remove unused code

2019-11-22 Thread Baesken, Matthias
Hi Erik, yes it makes the build more chatty - our linux s390 product build log of jdk/jdk goes from ~ 60.000 lines to ~ 123.000 lines with the patch. However the change is linux s390 only so I guess it will not disturb other people ( in case we bring it to more platforms

Re: RFR: 8234525: enable link-time section-gc for linux s390x to remove unused code

2019-11-22 Thread Erik Joelsson
Hello Matthias, This looks like an interesting change. If you want to enable this for s390x, I'm ok with it. If it works out well, perhaps we can find a way to expand this to other architectures. Do you really want to set --print-gc-sections by default? I would assume that makes the build