+1
Gruß, Thomas
On Wed, Feb 19, 2020, 10:35 Baesken, Matthias
wrote:
> Hello Thomas / Lance / Martin, thanks for the reviews .
>
> I added a little helper function, new webrev :
>
>
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8239351.1/
>
>
>
> Best regards, Matthias
>
>
>
>
>
>
>
> I
Hello Thomas / Lance / Martin, thanks for the reviews .
I added a little helper function, new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8239351.1/
Best regards, Matthias
I like this too. +1 for factoring out throwing the error.
..Thomas
On Tue, Feb 18, 2020 at 6:51 PM Martin
I like this too. +1 for factoring out throwing the error.
..Thomas
On Tue, Feb 18, 2020 at 6:51 PM Martin Buchholz wrote:
> Thanks for doing this. Looks good to me.
> I would probably create a tiny helper function to encapsulate the error
> throw.
>
> On Tue, Feb 18, 2020 at 7:03 AM Baesken,
I think this looks OK also
> On Feb 18, 2020, at 12:50 PM, Martin Buchholz wrote:
>
> Thanks for doing this. Looks good to me.
> I would probably create a tiny helper function to encapsulate the error
> throw.
>
> On Tue, Feb 18, 2020 at 7:03 AM Baesken, Matthias
> wrote:
>
>> Hello, please
Thanks for doing this. Looks good to me.
I would probably create a tiny helper function to encapsulate the error
throw.
On Tue, Feb 18, 2020 at 7:03 AM Baesken, Matthias
wrote:
> Hello, please review this change to Deflater.c .
>
> When running the jtreg test java/util/zip/DeInflate.java , we
