Re: Review request for #6783209

2012-01-04 Thread Xueming Shen
On 01/04/2012 09:54 AM, Alan Bateman wrote: On 04/01/2012 17:39, Iris Clark wrote: Hi, Brandon. Webrev: http://cr.openjdk.java.net/~bpassani/6783209/1/webrev/ You're revised webrev looks good to me. Looks good to me too. Sherman - you sponsored Brandon's previous update to Formatter, are

Re: Review request for #6783209

2012-01-04 Thread Alan Bateman
On 04/01/2012 17:39, Iris Clark wrote: Hi, Brandon. Webrev: http://cr.openjdk.java.net/~bpassani/6783209/1/webrev/ You're revised webrev looks good to me. Looks good to me too. Sherman - you sponsored Brandon's previous update to Formatter, are you planning to do the same this time?

RE: Review request for #6783209

2012-01-04 Thread Iris Clark
Hi, Brandon. > Webrev: http://cr.openjdk.java.net/~bpassani/6783209/1/webrev/ You're revised webrev looks good to me. Thanks, iris

Re: Review request for #6783209

2012-01-03 Thread Brandon Passanisi
Hi Iris. Answers below: On 1/3/2012 1:27 PM, Iris Clark wrote: Hi, Brandon. I am not a jdk8 Reviewer (http://openjdk.java.net/census#jdk8), but I am the original author. No time to check the spec now, but is precision ever applicable when the flag '%' is provided? If it is, then old line 2

RE: Review request for #6783209

2012-01-03 Thread Iris Clark
Hi, Brandon. I am not a jdk8 Reviewer (http://openjdk.java.net/census#jdk8), but I am the original author. No time to check the spec now, but is precision ever applicable when the flag '%' is provided? If it is, then old line 2726 should probably just be changed to "print("%')". Rather than