Re: RFR(M): 8150635: j.l.i.MethodHandles.loop(...) throws IndexOutOfBoundsException

2016-03-01 Thread Michael Haupt
Hi Paul, > Am 29.02.2016 um 14:46 schrieb Paul Sandoz : >> A new webrev with the above changes (save the renaming) is at >> http://cr.openjdk.java.net/~mhaupt/8150635/webrev.01 >> > > +1 thank you. I'll push once CCC approves. Best, Michael -- Dr. Michael Haupt |

Re: RFR(M): 8150635: j.l.i.MethodHandles.loop(...) throws IndexOutOfBoundsException

2016-02-29 Thread Paul Sandoz
> On 29 Feb 2016, at 14:39, Michael Haupt wrote: > >>> * @apiNote Example: >>> * {@code >>> * // iterative implementation of the factorial function as a loop handle >>> * static int one(int k) { return 1; } >>> * int inc(int i, int acc, int k) { return i + 1; } >>> ... >> >> Do you need to upda

Re: RFR(M): 8150635: j.l.i.MethodHandles.loop(...) throws IndexOutOfBoundsException

2016-02-29 Thread Michael Haupt
Hi Paul, thank you for your comments. BTW I filed a CCC request in the meantime, as this change also affects the details of when exceptions are thrown. Answers below ... > Am 29.02.2016 um 12:23 schrieb Paul Sandoz : > MethodHandles.java > — > > ... > You can use List.of() (or before that metho

Re: RFR(M): 8150635: j.l.i.MethodHandles.loop(...) throws IndexOutOfBoundsException

2016-02-29 Thread Paul Sandoz
> On 26 Feb 2016, at 14:01, Michael Haupt wrote: > > Dear all, > > please review this fix. > Bug: https://bugs.openjdk.java.net/browse/JDK-8150635 > Webrev: http://cr.openjdk.java.net/~mhaupt/8150635/webrev.00 > MethodHandles.java — 4087 private static List> buildCommonSuffix(List init,

RFR(M): 8150635: j.l.i.MethodHandles.loop(...) throws IndexOutOfBoundsException

2016-02-26 Thread Michael Haupt
Dear all, please review this fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8150635 Webrev: http://cr.openjdk.java.net/~mhaupt/8150635/webrev.00 There were two issues to address that led to IOOBE being thrown. 1. Lack of support for deriving the loop signature from given parameter type list