*Chuckle* at the long-obsolete reference in test/langtools/Makefile
292 apt:JTREG_TESTDIRS = tools/apt
Otherwise, apart from other overdue cleanup, test/langtools/Makefile
looks OK.
-- Jon
On 10/02/2018 12:21 AM, Mikael Vidstedt wrote:
Please review this change which removes
Looks good. Ship it!
David
On 3/10/2018 4:17 AM, Mikael Vidstedt wrote:
Thanks for the reviews. I’ve reverted the changes related to Helper and “just”
adjusted the comments instead.
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.01/open/webrev/
incremental (from
On 02/10/2018 19:17, Mikael Vidstedt wrote:
Thanks for the reviews. I’ve reverted the changes related to Helper and “just”
adjusted the comments instead.
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.01/open/webrev/
incremental (from webrev.00):
Looks good to me.
/Erik
On 2018-10-02 11:17, Mikael Vidstedt wrote:
Thanks for the reviews. I’ve reverted the changes related to Helper and “just”
adjusted the comments instead.
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.01/open/webrev/
incremental (from webrev.00):
+1
Mandy
On 10/2/18 11:17 AM, Mikael Vidstedt wrote:
Thanks for the reviews. I’ve reverted the changes related to Helper
and “just” adjusted the comments instead.
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.01/open/webrev/
Thanks for the reviews. I’ve reverted the changes related to Helper and “just”
adjusted the comments instead.
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.01/open/webrev/
incremental (from webrev.00):
Build changes look good to me.
/Erik
On 2018-10-02 00:21, Mikael Vidstedt wrote:
Please review this change which removes support for, and references to, the
(Oracle internal) JPRT system.
bug: https://bugs.openjdk.java.net/browse/JDK-8211350
webrev:
On 10/2/18 12:21 AM, Mikael Vidstedt wrote:
Please review this change which removes support for, and references to, the
(Oracle internal) JPRT system.
bug: https://bugs.openjdk.java.net/browse/JDK-8211350
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.00/open/webrev/
On 2/10/2018 6:34 PM, Alan Bateman wrote:
On 02/10/2018 08:21, Mikael Vidstedt wrote:
Please review this change which removes support for, and references
to, the (Oracle internal) JPRT system.
bug: https://bugs.openjdk.java.net/browse/JDK-8211350
webrev:
On 02/10/2018 08:21, Mikael Vidstedt wrote:
Please review this change which removes support for, and references to, the
(Oracle internal) JPRT system.
bug: https://bugs.openjdk.java.net/browse/JDK-8211350
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.00/open/webrev/
Does
Hi Mikael,
This all looks fine to me.
Thanks for cleaning it up!
David
On 2/10/2018 5:21 PM, Mikael Vidstedt wrote:
Please review this change which removes support for, and references to, the
(Oracle internal) JPRT system.
bug: https://bugs.openjdk.java.net/browse/JDK-8211350
webrev:
Please review this change which removes support for, and references to, the
(Oracle internal) JPRT system.
bug: https://bugs.openjdk.java.net/browse/JDK-8211350
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8211350/webrev.00/open/webrev/
* Background (from the issue)
The Oracle
12 matches
Mail list logo