Re: RFR(XS): 8188135: Fix VS 2010 build after "8187631: Refactor FileDescriptor close implementation"

2017-09-29 Thread Roger Riggs
+1 On 9/29/2017 4:43 AM, Alan Bateman wrote: On 29/09/2017 09:05, Lindenmaier, Goetz wrote: Hi, please review this tiny fix for the build with Visual Studio 2010: http://cr.openjdk.java.net/~goetz/wr17/8188135-winBuild/webrev.01/ Looks okay although I thought VS 2010 was dropped a long

RE: RFR(XS): 8188135: Fix VS 2010 build after "8187631: Refactor FileDescriptor close implementation"

2017-09-29 Thread Lindenmaier, Goetz
t;; core-libs- > d...@openjdk.java.net > Subject: Re: RFR(XS): 8188135: Fix VS 2010 build after "8187631: Refactor > FileDescriptor close implementation" > > > > On 29/09/2017 09:05, Lindenmaier, Goetz wrote: > > Hi, > > > > please review this tiny fix for the b

RE: RFR(XS): 8188135: Fix VS 2010 build after "8187631: Refactor FileDescriptor close implementation"

2017-09-29 Thread Lindenmaier, Goetz
d...@openjdk.java.net > Subject: Re: RFR(XS): 8188135: Fix VS 2010 build after "8187631: Refactor > FileDescriptor close implementation" > > On 29/09/2017 6:05 PM, Lindenmaier, Goetz wrote: > > Hi, > > > > please review this tiny fix for the build with Visual St

Re: RFR(XS): 8188135: Fix VS 2010 build after "8187631: Refactor FileDescriptor close implementation"

2017-09-29 Thread Alan Bateman
On 29/09/2017 09:05, Lindenmaier, Goetz wrote: Hi, please review this tiny fix for the build with Visual Studio 2010: http://cr.openjdk.java.net/~goetz/wr17/8188135-winBuild/webrev.01/ Looks okay although I thought VS 2010 was dropped a long time ago. -Alan

Re: RFR(XS): 8188135: Fix VS 2010 build after "8187631: Refactor FileDescriptor close implementation"

2017-09-29 Thread David Holmes
On 29/09/2017 6:05 PM, Lindenmaier, Goetz wrote: Hi, please review this tiny fix for the build with Visual Studio 2010: http://cr.openjdk.java.net/~goetz/wr17/8188135-winBuild/webrev.01/ Looks fine. One day we'll stop getting bitten by archaic compilers :( Cheers, David Best regards,

RFR(XS): 8188135: Fix VS 2010 build after "8187631: Refactor FileDescriptor close implementation"

2017-09-29 Thread Lindenmaier, Goetz
Hi, please review this tiny fix for the build with Visual Studio 2010: http://cr.openjdk.java.net/~goetz/wr17/8188135-winBuild/webrev.01/ Best regards, Goetz.