Re: RFR(XS): 8226286 Remove unused method java.lang.Integer::formatUnsignedInt

2019-06-19 Thread Brian Burkhalter
+1 Thanks, Brian > On Jun 19, 2019, at 4:49 AM, Claes Redestad wrote: > > On 2019-06-19 07:28, Tagir Valeev wrote: >> Hello, Brian! >> Thank you for review. Here's updated version: >> http://cr.openjdk.java.net/~tvaleev/webrev/8226286/r2/ >>

Re: RFR(XS): 8226286 Remove unused method java.lang.Integer::formatUnsignedInt

2019-06-19 Thread Claes Redestad
Hi Tagir, On 2019-06-19 07:28, Tagir Valeev wrote: Hello, Brian! Thank you for review. Here's updated version: http://cr.openjdk.java.net/~tvaleev/webrev/8226286/r2/ this looks like a good cleanup! It's partly my fault that these format methods ended up a bit messy. I exposed some of the int

Re: RFR(XS): 8226286 Remove unused method java.lang.Integer::formatUnsignedInt

2019-06-18 Thread Tagir Valeev
Hello, Brian! Thank you for review. Here's updated version: http://cr.openjdk.java.net/~tvaleev/webrev/8226286/r2/ I left dangling javadoc in-place in the same way as it's done in > java.lang.Long. > > > I don’t know whether this was intentional per some policy or an oversight. > Seems it was an

Re: RFR(XS): 8226286 Remove unused method java.lang.Integer::formatUnsignedInt

2019-06-18 Thread Brian Burkhalter
Hello, > On Jun 17, 2019, at 9:55 PM, Tagir Valeev wrote: > > Please review: > https://bugs.openjdk.java.net/browse/JDK-8226286 > > http://cr.openjdk.java.net/~tvaleev/webrev/8226286/r1/ >

RFR(XS): 8226286 Remove unused method java.lang.Integer::formatUnsignedInt

2019-06-17 Thread Tagir Valeev
Hello! Please review: https://bugs.openjdk.java.net/browse/JDK-8226286 http://cr.openjdk.java.net/~tvaleev/webrev/8226286/r1/ I left dangling javadoc in-place in the same way as it's done in java.lang.Long. Also I removed redundant reassignment of parameter like s = Objects.requireNonNull(s). B