Re: RFR(xs): JDK-8247605 Avoid array allocation when concatenating with empty string

2020-06-15 Thread Claes Redestad
Hi Tagir, changes looks good to me. Thanks! /Claes On 2020-06-15 18:45, Tagir Valeev wrote: Hello! Please review the following small change in StringConcatHelper::simpleConcat https://bugs.openjdk.java.net/browse/JDK-8247605 https://cr.openjdk.java.net/~tvaleev/webrev/8247605/r1/ This chang

RFR(xs): JDK-8247605 Avoid array allocation when concatenating with empty string

2020-06-15 Thread Tagir Valeev
Hello! Please review the following small change in StringConcatHelper::simpleConcat https://bugs.openjdk.java.net/browse/JDK-8247605 https://cr.openjdk.java.net/~tvaleev/webrev/8247605/r1/ This change improves the concatenation of empty string and non-empty string/object by reusing the internal b