Martin,
I've worked with Bhavesh to sort out these issues. The inconsistency in
the syntax has been fixed.
The CSS could be more compact ... if we did not have to deal with nested
tables. It was also a goal to simplify the use for the doc comment
author, such that it was possible to put jus
Looks good.
---
I suspect there's some way to specify the styles more compactly, but I
don't know enough css to say.
---
+table.borderless thead tr th, table.borderless tbody tr th,
table.borderless tr th,
+table.plain > thead > tr > th, table.plain > tbody > tr > th, table.plain
> tr > th,
I
Looks good.
Mandy
> On May 10, 2017, at 5:36 PM, Jonathan Gibbons
> wrote:
>
> Mandy,
>
> I have fixed the tables you noted.
>
> jdk (changes to java.base):
> http://cr.openjdk.java.net/~jjg/8179479-8179592/8179592/webrev.02/
>
> API showing the effect of these changes:
> http://cr.openjdk.
Mandy,
I have fixed the tables you noted.
jdk (changes to java.base):
http://cr.openjdk.java.net/~jjg/8179479-8179592/8179592/webrev.02/
API showing the effect of these changes:
http://cr.openjdk.java.net/~jjg/8179479-8179592/api.02/java.base-summary.html
-- Jon
On 05/10/2017 03:50 PM, Mand
> On May 5, 2017, at 3:52 PM, Jonathan Gibbons
> wrote:
>
> This is an updated review for the changes to improve tables in java.base.
> :
> Webrevs:
>
> langtools (the stylesheet):
> http://cr.openjdk.java.net/~jjg/8179479-8179592/8179479/webrev.01/
>
> jdk (changes to java.base):
> http://cr
Kumar,
The nature of CSS is such that there is generally no one single definition.
The descriptive comments are just before the shared/common parts of the
definitions.
If I grouped the comment and class definition, someone else would point
out that I could be
sharing common properties.
The b
Hi Jon,
I looked at the stylesheet can the descriptive comments for each of the
classes be moved closer to the class itself, ie. just before the
definition ?
Kumar
This is an updated review for the changes to improve tables in java.base.
The changes incorporate earlier review feedback, an
This is an updated review for the changes to improve tables in java.base.
The changes incorporate earlier review feedback, and also address a
problem that was discovered with nested tables.
The summary of the set of changes since the previous round is:
* A new style class is added for borderl
