Re: RFR: [jdk7u-dev] - 8003898: X11 toolkit can be chosen as the default toolkit

2013-01-25 Thread Rob McKenna
Had a chat with Alexey off list. Since 7162111 is indeed required to get these tests running on headless systems we've agreed to go ahead with this fix. (but not 8004928) A webrev with this change is at: http://cr.openjdk.java.net/~robm/7162111/webrev.02/

Re: RFR: [jdk7u-dev] - 8003898: X11 toolkit can be chosen as the default toolkit

2013-01-25 Thread Alexey Utkin
Looks good. Did you test the fix in ssh session to Mac? -uta On 25.01.2013 19:37, Rob McKenna wrote: Had a chat with Alexey off list. Since 7162111 is indeed required to get these tests running on headless systems we've agreed to go ahead with this fix. (but not 8004928) A webrev with this

Re: RFR: [jdk7u-dev] - 8003898: X11 toolkit can be chosen as the default toolkit

2013-01-25 Thread Kelly O'Hair
But the build uses applescript, preventing builds via ssh. But I commend this effort, I consider it important that our testing is as robust as possible. -kto On Jan 25, 2013, at 7:37 AM, Rob McKenna wrote: Had a chat with Alexey off list. Since 7162111 is indeed required to get these

Re: RFR: [jdk7u-dev] - 8003898: X11 toolkit can be chosen as the default toolkit

2013-01-25 Thread Rob McKenna
Yup, all affected tests pass in both jprt and via an ssh session to a mac. -Rob On 25/01/13 16:07, Alexey Utkin wrote: Looks good. Did you test the fix in ssh session to Mac? -uta On 25.01.2013 19:37, Rob McKenna wrote: Had a chat with Alexey off list. Since 7162111 is indeed required to

Re: RFR: [jdk7u-dev] - 8003898: X11 toolkit can be chosen as the default toolkit

2012-12-21 Thread Alan Bateman
On 20/12/2012 22:11, Stuart Marks wrote: Isn't 7162111 important to avoid hangs/failures when running the tests on the Mac? Plus it removes tests from the problem list so we get better test coverage in 7u. 8003898 is the change to not select the XToolkit and I think is the most important to

Re: RFR: [jdk7u-dev] - 8003898: X11 toolkit can be chosen as the default toolkit

2012-12-20 Thread Stuart Marks
On 12/19/12 12:32 AM, Alan Bateman wrote: On 17/12/2012 18:46, Rob McKenna wrote: Hi folks, This review contains: 8003898: X11 toolkit can be chosen as the default toolkit 7162111: TEST_BUG: change tests run in headless mode [macosx] (open) 8004928: TEST_BUG: Reduce dependence of CoreLib

Re: RFR: [jdk7u-dev] - 8003898: X11 toolkit can be chosen as the default toolkit

2012-12-19 Thread Alexey Utkin
Looks good for me. On 17.12.2012 22:46, Rob McKenna wrote: Hi folks, This review contains: 8003898: X11 toolkit can be chosen as the default toolkit 7162111: TEST_BUG: change tests run in headless mode [macosx] (open) 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT

Re: RFR: [jdk7u-dev] - 8003898: X11 toolkit can be chosen as the default toolkit

2012-12-19 Thread Alan Bateman
On 17/12/2012 18:46, Rob McKenna wrote: Hi folks, This review contains: 8003898: X11 toolkit can be chosen as the default toolkit 7162111: TEST_BUG: change tests run in headless mode [macosx] (open) 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Unfortunately

RFR: [jdk7u-dev] - 8003898: X11 toolkit can be chosen as the default toolkit

2012-12-17 Thread Rob McKenna
Hi folks, This review contains: 8003898: X11 toolkit can be chosen as the default toolkit 7162111: TEST_BUG: change tests run in headless mode [macosx] (open) 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Unfortunately the last two patches didn't apply cleanly,