Re: RFR: 8023113: tools/jar/ChangeDir.java fails if /tmp/a exists

2013-09-19 Thread Alan Bateman
On 18/09/2013 20:45, Xueming Shen wrote: OK, how about this one? I'm even using lambda:-) http://cr.openjdk.java.net/~sherman/8023113/webrev/ -Sherman Looks okay except that Files.list returns a stream that needs to be closed to avoid leaking resources. As a side note, as cleanup is

Re: RFR: 8023113: tools/jar/ChangeDir.java fails if /tmp/a exists

2013-09-19 Thread Xueming Shen
On 9/19/2013 1:52 AM, Alan Bateman wrote: On 18/09/2013 20:45, Xueming Shen wrote: OK, how about this one? I'm even using lambda:-) http://cr.openjdk.java.net/~sherman/8023113/webrev/ -Sherman Looks okay except that Files.list returns a stream that needs to be closed to avoid leaking

Re: RFR: 8023113: tools/jar/ChangeDir.java fails if /tmp/a exists

2013-09-18 Thread Alan Bateman
On 17/09/2013 22:55, Xueming Shen wrote: Hi, Please help the small update to the test case tools/jar/ChangeDir.java, which might fail if the dedicated test directory /tmp/a exists and the user does not have privilege to delete/clean it up. The proposed change here is to use a random file name

Re: RFR: 8023113: tools/jar/ChangeDir.java fails if /tmp/a exists

2013-09-18 Thread Xueming Shen
OK, how about this one? I'm even using lambda:-) http://cr.openjdk.java.net/~sherman/8023113/webrev/ -Sherman On 09/18/2013 09:42 AM, Xueming Shen wrote: On 09/18/2013 03:31 AM, Alan Bateman wrote: On 17/09/2013 22:55, Xueming Shen wrote: Hi, Please help the small update to the test case

RFR: 8023113: tools/jar/ChangeDir.java fails if /tmp/a exists

2013-09-17 Thread Xueming Shen
Hi, Please help the small update to the test case tools/jar/ChangeDir.java, which might fail if the dedicated test directory /tmp/a exists and the user does not have privilege to delete/clean it up. The proposed change here is to use a random file name (from File.getTempFile()) for the top test