Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2022-02-08 Thread Raffaello Giulietti
On Tue, 8 Feb 2022 20:18:22 GMT, Brian Burkhalter wrote: >> The work (the code) has been published here on GitHub, so afaik the >> copyright year cannot be simply changed without modifying something (beside >> the year itself, which would be self-justifying) > > @rgiulietti You are correct: no

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2022-02-08 Thread Brian Burkhalter
On Tue, 8 Feb 2022 20:06:38 GMT, Raffaello Giulietti wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 4511638: Double.toString(double) sometimes produces incorrect results >> >> Enhanced intervals in

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2022-02-08 Thread Brian Burkhalter
On Tue, 8 Feb 2022 19:51:53 GMT, Raffaello Giulietti wrote: >> @rgiulietti Also the copyright year. So no further substantive updates >> needed? > > @bplb Why the copyright year? Nothing is expected to change, except for the > test mentioned. @rgiulietti Well you know I am not sure about the

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2022-02-08 Thread Raffaello Giulietti
On Mon, 15 Nov 2021 19:31:09 GMT, Raffaello Giulietti wrote: >> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2022-02-08 Thread Brian Burkhalter
On Tue, 8 Feb 2022 19:41:48 GMT, Raffaello Giulietti wrote: >> @rgiulietti Should we expect any more commits from you in this PR? Thanks. > > @bplb The last commit was pushed on Nov 15. > I guess I would have to merge against the latest master because of >

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2022-02-08 Thread Raffaello Giulietti
On Tue, 8 Feb 2022 19:47:25 GMT, Brian Burkhalter wrote: >> @bplb The last commit was pushed on Nov 15. >> I guess I would have to merge against the latest master because of >> test/langtools/tools/javac/sym/ElementStructureTest.java >> and the intervening switch from JDK18 to JDK19. > >

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2022-02-08 Thread Raffaello Giulietti
On Tue, 8 Feb 2022 19:23:54 GMT, Brian Burkhalter wrote: >> En attendant go! go! > > @rgiulietti Should we expect any more commits from you in this PR? Thanks. @bplb The last commit was pushed on Nov 15. I guess I would have to merge against the latest master because of

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2022-02-08 Thread Brian Burkhalter
On Tue, 11 Jan 2022 09:30:49 GMT, Raffaello Giulietti wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 4511638: Double.toString(double) sometimes produces incorrect results >> >> Enhanced intervals in

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2022-02-08 Thread Suminda Sirinath Salpitikorala Dharmasena
On Mon, 15 Nov 2021 19:31:09 GMT, Raffaello Giulietti wrote: >> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2022-01-11 Thread Raffaello Giulietti
On Mon, 15 Nov 2021 19:31:09 GMT, Raffaello Giulietti wrote: >> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2021-12-15 Thread Suminda Sirinath Salpitikorala Dharmasena
On Mon, 15 Nov 2021 19:31:09 GMT, Raffaello Giulietti wrote: >> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2021-11-17 Thread GuySteele
On Mon, 15 Nov 2021 19:31:09 GMT, Raffaello Giulietti wrote: >> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2021-11-17 Thread Raffaello Giulietti
Hi Suminda, please read my reply to you from May https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-May/077081.html Greetings Raffaello On 2021-11-17 14:54, Suminda Sirinath Salpitikorala Dharmasena wrote: On Mon, 15 Nov 2021 19:31:09 GMT, Raffaello Giulietti wrote: Hello,

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2021-11-17 Thread Suminda Sirinath Salpitikorala Dharmasena
On Mon, 15 Nov 2021 19:31:09 GMT, Raffaello Giulietti wrote: >> Hello, >> >> here's a PR for a patch submitted on March 2020 >> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was >> a thing. >> >> The patch has been edited to adhere to OpenJDK code conventions about

Re: RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

2021-11-15 Thread Raffaello Giulietti
> Hello, > > here's a PR for a patch submitted on March 2020 > [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a > thing. > > The patch has been edited to adhere to OpenJDK code conventions about > multi-line (block) comments. Nothing in the code proper has