On Mar 27, 2021, at 12:44 PM, Alan Bateman
mailto:al...@openjdk.java.net>> wrote:
Dear Lance,
Sorry that I reply so late, I got stuck at some work recently.
* We should have tests that include some , but not all of the additional fields
as I believe they are all optional according to the
On Fri, 26 Mar 2021 02:14:54 GMT, Lin Zang wrote:
>> Hi Lin,
>>
>> On Mar 24, 2021, at 2:51 AM, Lin Zang ***@***.**@***.***>> wrote:
>>
>>
>>
>> Hi Lance,
>> Thanks a lot for your review. I will update the PR ASAP.
>> May I ask your help to also review the CSR?
>>
>> I believe we need
On Mon, 22 Mar 2021 20:18:37 GMT, Lance Andersen wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - update copyright
>> - reuse arguments constructor for non-argument one.
>
>
On Mon, 22 Mar 2021 20:15:38 GMT, Lance Andersen wrote:
> on operating systems using
> EBCDIC or any other character set for file names, the name
> must be translated to the ISO LATIN-1 character set. This
> is the original name of the file being compressed, with any
>
On Mon, 22 Mar 2021 20:06:33 GMT, Lance Andersen wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - update copyright
>> - reuse arguments constructor for non-argument one.
>
>
On Wed, 24 Mar 2021 10:25:44 GMT, Lance Andersen wrote:
>> Hi Lance,
>> Thanks a lot for your review. I will update the PR ASAP.
>> May I ask your help to also review the CSR? Thanks!
>>
>> BRs,
>> Lin
>
> Hi Lin,
>
> On Mar 24, 2021, at 2:51 AM, Lin Zang ***@***.**@***.***>> wrote:
>
>
On Wed, 24 Mar 2021 06:51:16 GMT, Lin Zang wrote:
>> Hi Lin,
>>
>> Again, thank you for taking on this 19+ year feature request.
>>
>> I have not done a deep dive on the CSR, but wanted to get a few comments
>> back to you on a quick scan of the last PR update.
>>
>> Personally, I would
On Mon, 22 Mar 2021 21:37:27 GMT, Lance Andersen wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - update copyright
>> - reuse arguments constructor for non-argument one.
>
> Hi Lin,
>
> Again, thank you for taking
On Fri, 19 Mar 2021 08:19:58 GMT, Lin Zang wrote:
>> 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional
>> GZIP fields
>
> Lin Zang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - update copyright
> - reuse
> 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional
> GZIP fields
Lin Zang has updated the pull request incrementally with two additional commits
since the last revision:
- update copyright
- reuse arguments constructor for non-argument one.
-
Changes:
10 matches
Mail list logo