Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-26 Thread wxiang
On Tue, 31 Aug 2021 12:11:46 GMT, wxiang wrote: > Using jarIndex for Hibench, there is an unexpected behavior with the > exception "Exception in thread "main" > org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme > "hdfs"". > > After investigating it, it is related

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-06 Thread wxiang
On Tue, 31 Aug 2021 12:11:46 GMT, wxiang wrote: > Using jarIndex for Hibench, there is an unexpected behavior with the > exception "Exception in thread "main" > org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme > "hdfs"". > > After investigating it, it is related

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-05 Thread Alan Bateman
On 04/09/2021 12:12, Lance Andersen wrote: Perhaps the jar validate option could/should be updated to flag when an index is there? We could add a warning for JDK 18 when main::genIndex is invoked as I assume we would want to at least wait until JDK19 to remove this functionality? I'm not

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-04 Thread Lance Andersen
On Sep 4, 2021, at 2:53 AM, Alan Bateman mailto:al...@openjdk.java.net>> wrote: On Sat, 4 Sep 2021 01:53:35 GMT, wxiang mailto:github.com+53162078+shiyu...@openjdk.org>> wrote: I will first create the patch to remove JAR index support from the URLClassLoader implementation, the `jar i`

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-04 Thread Alan Bateman
On Sat, 4 Sep 2021 01:53:35 GMT, wxiang wrote: > I will first create the patch to remove JAR index support from the > URLClassLoader implementation, the `jar i` option. Thank you. We'll probably need a new JBS issue and PR for that but let's see first if any issues come out of the wood work.

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-03 Thread wxiang
On Fri, 3 Sep 2021 10:48:01 GMT, Alan Bateman wrote: > > @AlanBateman Sure, I am interested in it. > > Great! I think there are several parts to this. The removal of the JAR index > support from the URLClassLoader implementation, the `jar i` option, the JAR > file spec, and the jar tool man

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-03 Thread Stuart Marks
On Fri, 3 Sep 2021 10:48:01 GMT, Alan Bateman wrote: > There will probably need to be some discussion on what to do with the jar > tool. I suspect we will need to keep the code that updates the index when > updating a JAR file that has an existing index, this means keeping > JarIndex

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-03 Thread Alan Bateman
On Thu, 2 Sep 2021 11:43:46 GMT, Alan Bateman wrote: >> Using jarIndex for Hibench, there is an unexpected behavior with the >> exception "Exception in thread "main" >> org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for >> scheme "hdfs"". >> >> After investigating it, it

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-03 Thread wxiang
On Thu, 2 Sep 2021 11:43:46 GMT, Alan Bateman wrote: >> Using jarIndex for Hibench, there is an unexpected behavior with the >> exception "Exception in thread "main" >> org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for >> scheme "hdfs"". >> >> After investigating it, it

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-02 Thread Alan Bateman
On Tue, 31 Aug 2021 12:11:46 GMT, wxiang wrote: > Using jarIndex for Hibench, there is an unexpected behavior with the > exception "Exception in thread "main" > org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme > "hdfs"". > > After investigating it, it is related

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-01 Thread Daniel Fuchs
On Tue, 31 Aug 2021 12:11:46 GMT, wxiang wrote: > Using jarIndex for Hibench, there is an unexpected behavior with the > exception "Exception in thread "main" > org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme > "hdfs"". > > After investigating it, it is related

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-01 Thread Alan Bateman
On Tue, 31 Aug 2021 12:11:46 GMT, wxiang wrote: > Using jarIndex for Hibench, there is an unexpected behavior with the > exception "Exception in thread "main" > org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme > "hdfs"". > > After investigating it, it is related

RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-08-31 Thread wxiang
Using jarIndex for Hibench, there is an unexpected behavior with the exception "Exception in thread "main" org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme "hdfs"". After investigating it, it is related to the usage of ServiceLoader with JarIndex. The below stack