Re: RFR: 7130985: Four helper classes missing in Sun JDK

2015-06-08 Thread Seán Coffey
Looks good to me too. Regards, Sean. On 08/06/15 13:30, Mark Sheppard wrote: Hi Rob, looks fine to me thanks for handling this issue regards Mark On 05/06/2015 15:41, Rob McKenna wrote: Added some cleanup code around the BufferedReaders & the leftover test files: http://cr.openjdk.jav

Re: RFR: 7130985: Four helper classes missing in Sun JDK

2015-06-08 Thread Mark Sheppard
Hi Rob, looks fine to me thanks for handling this issue regards Mark On 05/06/2015 15:41, Rob McKenna wrote: Added some cleanup code around the BufferedReaders & the leftover test files: http://cr.openjdk.java.net/~robm/7130985/webrev.02/ -Rob On 03/06/15 16:20, Rob McKenna wrote:

Re: RFR: 7130985: Four helper classes missing in Sun JDK

2015-06-05 Thread Rob McKenna
Added some cleanup code around the BufferedReaders & the leftover test files: http://cr.openjdk.java.net/~robm/7130985/webrev.02/ -Rob On 03/06/15 16:20, Rob McKenna wrote: Meant to get this sorted a while back. There was a thread on this last year ( http://mail.openjdk.java.net/pipe

RFR: 7130985: Four helper classes missing in Sun JDK

2015-06-03 Thread Rob McKenna
Meant to get this sorted a while back. There was a thread on this last year ( http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-July/027779.html ) A test has been added since then: http://cr.openjdk.java.net/~robm/7130985/webrev.corba/ http://cr.openjdk.java.net/~robm/7130985/webrev.j

Re: RFR: 7130985: Four helper classes missing in Sun JDK

2014-07-16 Thread Mark Sheppard
Hi Alan, we retrieved the IDL from the OMG web site http://www.omg.org/spec/CORBAe/20080201/CORBA_TypeCode.idl to regenerate the Helper classes ... this didn't compile properly and had to be manipulated to get the relevant exceptions required IvalidName is defined in http://www.omg.org/spec/CO

Re: RFR: 7130985: Four helper classes missing in Sun JDK

2014-07-15 Thread Alan Bateman
On 15/07/2014 18:27, Rob McKenna wrote: Hi folks, Looking for a review for the following: bug: https://bugs.openjdk.java.net/browse/JDK-7130985 webrev: http://cr.openjdk.java.net/~robm/7130985/webrev.01/ As per the bug report: The IDLtoJava spec clearly specifies the need of the helper class

RFR: 7130985: Four helper classes missing in Sun JDK

2014-07-15 Thread Rob McKenna
Hi folks, Looking for a review for the following: bug: https://bugs.openjdk.java.net/browse/JDK-7130985 webrev: http://cr.openjdk.java.net/~robm/7130985/webrev.01/ As per the bug report: The IDLtoJava spec clearly specifies the need of the helper class (not the Holder) for these files. But the