Re: RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-10-25 Thread Jim Gish
OK. One more time. http://cr.openjdk.java.net/~jgish/Bug7159567-set-logging-MemoryHandler I compromised with the RuntimeException. I'm instead catching it, but throwing a new one this way: 65 throw new RuntimeException( 66 Test Failed: did not load

Re: RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-10-25 Thread Mandy Chung
On 10/25/2012 10:25 AM, Jim Gish wrote: OK. One more time. http://cr.openjdk.java.net/~jgish/Bug7159567-set-logging-MemoryHandler Great, thanks! I'll push it for you. I compromised with the RuntimeException. I'm instead catching it, but throwing a new one this way: 65

Re: RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-10-24 Thread Jim Gish
See updated webrev: http://cr.openjdk.java.net/~jgish/Bug7159567-set-logging-MemoryHandler Thanks, Jim On 10/17/2012 03:46 PM, Mandy Chung wrote: Hi Jim, On 10/11/2012 2:37 PM, Jim Gish wrote: Please review the updated changes at

Re: RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-10-24 Thread Mandy Chung
On 10/24/2012 12:31 PM, Jim Gish wrote: See updated webrev: http://cr.openjdk.java.net/~jgish/Bug7159567-set-logging-MemoryHandler Looks good. Thanks for the update. MemoryHandlerTest.java - thanks for renaming it but you forget to change L28 @run tag. jtreg should fail if you run this

Re: RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-10-17 Thread Jim Gish
Fixed. Just needed to change a ul to /ul in StreamHandler.java Jim On 10/17/2012 02:46 PM, Jim Gish wrote: I just discovered a small syntax error in StreamHandler (thanks to specdiff :-)). I'll regenerate the webrev shortly. Jim On 10/17/2012 12:41 PM, Jim Gish wrote: Thanks. I believe

Re: RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-10-15 Thread Jim Gish
Here's an updated webrev that fixes some javadoc syntax issues: http://cr.openjdk.java.net/~jgish/Bug7159567-set-logging-MemoryHandler/ http://cr.openjdk.java.net/%7Ejgish/Bug7159567-set-logging-MemoryHandler/ Thanks, Jim On 10/11/2012 05:37 PM, Jim Gish wrote: Please review the updated

Re: RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-09-28 Thread Jim Gish
I've re-spun the change with additional usage notes in the spec to reflect the long-standing actual behavior. Note that it doesn't change the spec per se, as it was already stated in LogManager. This change simply replicates that language with an example in each *Handler class to make it

Re: RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-09-28 Thread Mandy Chung
On 9/28/2012 12:13 PM, Jim Gish wrote: I've re-spun the change with additional usage notes in the spec to reflect the long-standing actual behavior. Note that it doesn't change the spec per se, as it was already stated in LogManager. This change simply replicates that language with an example

Re: RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-09-26 Thread Jim Gish
Sorry -- wrong list -- I mean to send to the openjdk list. On 09/26/2012 05:19 PM, Jim Gish wrote: Please review http://cr.openjdk.java.net/~jgish/Bug7159567-set-MemoryHandler-target/ http://cr.openjdk.java.net/%7Ejgish/Bug7159567-set-MemoryHandler-target/ Overview - currently you can

Re: RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-09-26 Thread Jim Gish
Time to go home :-( I did send to the right list-- it's just that my mailer didn't show the whole address. Yikes! Sorry about the spam. Please review as originally requested. On 09/26/2012 06:21 PM, Jim Gish wrote: Sorry -- wrong list -- I mean to send to the openjdk list. On 09/26/2012

RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-09-26 Thread Jim Gish
Please review http://cr.openjdk.java.net/~jgish/Bug7159567-set-MemoryHandler-target/ http://cr.openjdk.java.net/%7Ejgish/Bug7159567-set-MemoryHandler-target/ Overview - currently you can sub-class java.util.logging.MemoryHandler and specify its configuration in a logging.properties file via

Re: RFR: 7159567 - inconsistent configuration of MemoryHandler

2012-09-26 Thread Mandy Chung
Hi Jim, On 9/26/2012 2:19 PM, Jim Gish wrote: Please review http://cr.openjdk.java.net/~jgish/Bug7159567-set-MemoryHandler-target/ http://cr.openjdk.java.net/%7Ejgish/Bug7159567-set-MemoryHandler-target/ Overview - currently you can sub-class java.util.logging.MemoryHandler and specify