Re: RFR: 8004317 TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported

2012-12-05 Thread Jim Gish
Thanks for the suggestions, Stuart. BTW printStackTrace() prints to standard error by default -- that's why I don't explicitly have it in there. Cheers, Jim On 12/04/2012 07:06 PM, Stuart Marks wrote: Hi Jim, (Looks like you're cleaning up warnings along the way. I guess that's OK.)

Re: RFR: 8004317 TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported

2012-12-05 Thread Stuart Marks
On 12/5/12 8:41 AM, Jim Gish wrote: BTW printStackTrace() prints to standard error by default -- that's why I don't explicitly have it in there. Oh yes, so it does. Sorry, I was confused. s'marks

Re: RFR: 8004317 TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported

2012-12-05 Thread Jim Gish
Here's a new version for your consideration :-) http://cr.openjdk.java.net/~jgish/Bug8004317-TestLibrary-getUnusedRandomPort-Failure/ http://cr.openjdk.java.net/%7Ejgish/Bug8004317-TestLibrary-getUnusedRandomPort-Failure/ Thanks, Jim On 12/05/2012 02:45 PM, Stuart Marks wrote: On 12/5/12

Re: RFR: 8004317 TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported

2012-12-05 Thread Stuart Marks
OK, looks better, more explicit so that we can find out why this is failing. There's still a subtle issue in the reporting though. Consider if on attempt N the ServerSocket call gets a valid port but it's one of the reserved ports. Then, unusedRandomPort will be = 0 and isReservedPort() will

Re: RFR: 8004317 TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported

2012-12-05 Thread Jim Gish
Thanks Stuart. Sure - go ahead and make the change and do the push. Maybe we'll get lucky with the nightlies! Thanks again, Jim On 12/05/2012 06:54 PM, Stuart Marks wrote: OK, looks better, more explicit so that we can find out why this is failing. There's still a subtle issue in the

Re: RFR: 8004317 TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported

2012-12-05 Thread Stuart Marks
Pushed: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a971516029ab I couldn't resist doing a couple more fixups. (Man, there is a lot more cleaning up that could be done in here.) I don't know if I got this in time for tonight's nightly. Well, get it in there and see if it falls over sooner or