Hi Stuart,
Looks good to me.
Thanks,
Jim
On 12/19/2012 08:11 PM, Stuart Marks wrote:
Hi all,
Please review the fix [1] for bug 8005290 [2].
[1] http://cr.openjdk.java.net/~smarks/reviews/8005290/webrev.0/
[2] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005290
I just filed this
From my limited knowledge of this, it look ok to me.
-Chris.
On 20/12/2012 01:11, Stuart Marks wrote:
Hi all,
Please review the fix [1] for bug 8005290 [2].
[1] http://cr.openjdk.java.net/~smarks/reviews/8005290/webrev.0/
[2] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005290
I
Hi Stuart,
the changes look fine to me. The only comments I have are to remove
the java.util.Properties import from JavaVM and possibly to use explicit
imports instead of * imports in JavaVM and StreamPipe.
Darryl
On 12/19/2012 05:11 PM, Stuart Marks wrote:
Hi all,
Please review the
Ah, good suggestion. I've cleaned up the imports in JavaVM.java and
StreamPipe.java.
s'marks
On 12/20/12 10:36 AM, Darryl Mocek wrote:
Hi Stuart,
the changes look fine to me. The only comments I have are to remove the
java.util.Properties import from JavaVM and possibly to use explicit
Hi all,
Please review the fix [1] for bug 8005290 [2].
[1] http://cr.openjdk.java.net/~smarks/reviews/8005290/webrev.0/
[2] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005290
I just filed this bug, so it hasn't made it to the public website yet. The
salient text from the bug report