Re: RFR: 8006534 CLONE - TestLibrary.getUnusedRandomPort() fails intermittently-doesn't retry enough times

2013-01-18 Thread Darryl Mocek
Hi Jim, I think this change looks fine. I think it works for our purposes for now and is a quick and painless change. The problem as I understand it is that when getUnusedRandomPort is called and the port returned is FIXED_PORT_MIN (which is rejected), then the code tries again and

RFR: 8006534 CLONE - TestLibrary.getUnusedRandomPort() fails intermittently-doesn't retry enough times

2013-01-17 Thread Jim Gish
Please review http://cr.openjdk.java.net/~jgish/Bug8006534-getUnusedRandomPort-retry-more/ http://cr.openjdk.java.net/%7Ejgish/Bug8006534-getUnusedRandomPort-retry-more/ TestLibrary.getUnusedPort() attempts to retry getting an ephemeral port 10 times, which is the current number of ports in

Re: RFR: 8006534 CLONE - TestLibrary.getUnusedRandomPort() fails intermittently-doesn't retry enough times

2013-01-17 Thread Mike Duigou
Seems entirely reasonable. On Jan 17 2013, at 12:18 , Jim Gish wrote: Please review http://cr.openjdk.java.net/~jgish/Bug8006534-getUnusedRandomPort-retry-more/ http://cr.openjdk.java.net/%7Ejgish/Bug8006534-getUnusedRandomPort-retry-more/ TestLibrary.getUnusedPort() attempts to retry