Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-11-06 Thread Alan Bateman
On 06/11/2013 03:51, Mike Duigou wrote: I have updated the webrev to backout the changes to how JT_HOME is set. This will be addressed in the next set of changes (8020779 https://bugs.openjdk.java.net/browse/JDK-8020779 and 8009683 https://bugs.openjdk.java.net/browse/JDK-8009683) which will

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-11-06 Thread Mike Duigou
Thank you for the review! On Nov 6 2013, at 09:11 , Alan Bateman alan.bate...@oracle.com wrote: On 06/11/2013 03:51, Mike Duigou wrote: I have updated the webrev to backout the changes to how JT_HOME is set. This will be addressed in the next set of changes (8020779

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-11-05 Thread Mike Duigou
One final set of changes was required based upon cross platform testing. The revised webrev which passes cross platform testing on all platforms is here: http://cr.openjdk.java.net/~mduigou/JDK-8015068/3/webrev/ The changes are: - I had to switch to using uname -s because Solaris doesn't

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-11-05 Thread David Holmes
Hi Mike, Won't pretend I follow all the changes, but how did you get rid of the platform-specific checks in the ProblemList ? Will jtreg figure that part out for itself? Also what is the failure mode if JT_HOME is not set and jtreg is not in the path? Should we just fail in that case before

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-11-05 Thread Mike Duigou
On Nov 5 2013, at 17:20 , David Holmes david.hol...@oracle.com wrote: Hi Mike, Won't pretend I follow all the changes, but how did you get rid of the platform-specific checks in the ProblemList ? Will jtreg figure that part out for itself? Yes. JTReg has had this ability for a while and

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-11-05 Thread Mike Duigou
I have updated the webrev to backout the changes to how JT_HOME is set. This will be addressed in the next set of changes (8020779 https://bugs.openjdk.java.net/browse/JDK-8020779 and 8009683 https://bugs.openjdk.java.net/browse/JDK-8009683) which will revisit how JT_HOME is set and how the

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-10-17 Thread Alan Bateman
On 16/10/2013 21:22, Mike Duigou wrote: Hello all; With the imminent promotion of JTReg 4.1b07 it's possible to finally consider completing this changeset! http://cr.openjdk.java.net/~mduigou/JDK-8015068/2/webrev/ This updated webrev includes handling of the shared library permissions.

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-10-16 Thread Mike Duigou
Hello all; With the imminent promotion of JTReg 4.1b07 it's possible to finally consider completing this changeset! http://cr.openjdk.java.net/~mduigou/JDK-8015068/2/webrev/ This updated webrev includes handling of the shared library permissions. Thanks, Mike On Aug 28 2013, at 04:11 , Alan

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-08-28 Thread Alan Bateman
On 28/08/2013 00:17, Mike Duigou wrote: Hello all; I have updated the changeset for this issue based upon feedback from the earlier version. As a result of intervening work this version contains even more cleanup. http://cr.openjdk.java.net/~mduigou/JDK-8015068/1/webrev/ Since the last

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-08-27 Thread Mike Duigou
Hello all; I have updated the changeset for this issue based upon feedback from the earlier version. As a result of intervening work this version contains even more cleanup. http://cr.openjdk.java.net/~mduigou/JDK-8015068/1/webrev/ Since the last revision: - One open issue remains--handling

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-08-27 Thread Kelly O'Hair
Nice. I think deleting code should be like hazard pay, double the normal hourly wage, but deleting Makefile lines should be triple wage. :) Looks great to me. Not that I use this makefile much anymore. -kto On Aug 27, 2013, at 4:17 PM, Mike Duigou wrote: Hello all; I have updated the

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-08-08 Thread Jonathan Gibbons
On 08/08/2013 09:13 AM, Chris Hegarty wrote: So we need a b07 of jtreg before we can proceed with this? -Chris. General question to all: How much will fall over if we call it 4.2? -- Jon

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-08-08 Thread Mike Duigou
On 2013-08-08, at 9:22, Jonathan Gibbons jonathan.gibb...@oracle.com wrote: On 08/08/2013 09:13 AM, Chris Hegarty wrote: So we need a b07 of jtreg before we can proceed with this? -Chris. General question to all: How much will fall over if we call it 4.2? Some of the build scripts

RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-08-07 Thread Mike Duigou
Hello all; This changesest simplifies how the the jdk/test/Makefile processes excluded tests. Previously the test exclusions were pre-processed by scripts in the Makefile before being passed to JTReg. JTReg will now the all the processing. The change depends upon improvements in JTReg since

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-08-07 Thread Alan Bateman
On 07/08/2013 14:44, Mike Duigou wrote: Hello all; This changesest simplifies how the the jdk/test/Makefile processes excluded tests. Previously the test exclusions were pre-processed by scripts in the Makefile before being passed to JTReg. JTReg will now the all the processing. The change

Re: RFR: 8015068 : (m) Use jtreg -exclude for problemlist.txt processing

2013-08-07 Thread Mike Duigou
On 2013-08-07, at 18:22, Alan Bateman alan.bate...@oracle.com wrote: On 07/08/2013 14:44, Mike Duigou wrote: Hello all; This changesest simplifies how the the jdk/test/Makefile processes excluded tests. Previously the test exclusions were pre-processed by scripts in the Makefile