Re: RFR: 8022446: Fix serial warnings in java.util.stream

2013-08-07 Thread Paul Sandoz
On Aug 6, 2013, at 10:28 PM, Henry Jen henry@oracle.com wrote: Hi, Please review a webrev[1] clean up on serial warning, as we don't intend to serialize those tasks, we simply suppress those warnings. It would be nice if there is a way to undo serializable. [1]

RFR: 8022446: Fix serial warnings in java.util.stream

2013-08-06 Thread Henry Jen
Hi, Please review a webrev[1] clean up on serial warning, as we don't intend to serialize those tasks, we simply suppress those warnings. It would be nice if there is a way to undo serializable. [1] http://cr.openjdk.java.net/~henryjen/tl/8022446/0/webrev/ Cheers, Henry

Re: RFR: 8022446: Fix serial warnings in java.util.stream

2013-08-06 Thread Tom Hawtin
Are you happy with the API docs in docs/api/serialized-form.html? Tom On 06/08/2013 14:28, Henry Jen wrote: Hi, Please review a webrev[1] clean up on serial warning, as we don't intend to serialize those tasks, we simply suppress those warnings. It would be nice if there is a way to undo

Re: RFR: 8022446: Fix serial warnings in java.util.stream

2013-08-06 Thread Henry Jen
On 08/06/2013 03:01 PM, Tom Hawtin wrote: Are you happy with the API docs in docs/api/serialized-form.html? Those are all internal classes, thus is not showing up on that page at all. I assume this is the concern? Cheers, Henry

Re: RFR: 8022446: Fix serial warnings in java.util.stream

2013-08-06 Thread Joe Darcy
Hello, In ReduceOps.java, I recommend replacing 46 * Factory for the creating instances of {@code TerminalOp} that implement with something like Factory for creating instances of {@code TerminalOp} that implement... Otherwise, the changes look good. Thanks, -Joe On 08/06/2013

Re: RFR: 8022446: Fix serial warnings in java.util.stream

2013-08-06 Thread Tom Hawtin
I'm not sure what the criteria for inclusion is. javax.security.auth.PrivateCredentialPermission.CredOwner, for example, appears but isn't in the normal API docs. It's also worth noting that the classes are still serialisable and deserialisable. Tom On 06/08/2013 15:54, Henry Jen wrote: On