Thanks for the reviews, guys.
I think you meant, long term we should look to providing this functionality in
some other way **and throw all of these packages into the trash!** :-)
s'marks
On 8/7/13 11:56 AM, Joe Darcy wrote:
Hi Stuart,
I believe the code in its current state out in review
Hi Stuart,
I believe the code in its current state out in review is a good
trade-off of effort needed to address the warnings vs improvement in the
quality of the code.
Certainly the code would benefit from a larger cleanup, but I agree that
is not warranted at this point. Longer term, say f
Hi Stuart,
On the surface the changes look fine, including what you did for SwitchData.
Certainly another pair of eyes would be good also on this.
Best
Lance
On Aug 7, 2013, at 2:28 AM, Stuart Marks wrote:
> Hi,
>
> Please review the fix for this warnings cleanup bug.
>
> Bug: http://bugs.sun
Hi,
Please review the fix for this warnings cleanup bug.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8022479
(not yet available publicly, but should be shortly)
Webrev: http://cr.openjdk.java.net/~smarks/reviews/8022479/webrev.0/
There are a few items of note.
This is *very* o
