Re: RFR: 8024500: Missing API coverage for java.util.function.BiFunction andThen

2013-09-11 Thread Alan Bateman
On 11/09/2013 06:03, Henry Jen wrote: Sorry I forgot it again. Copied but not pasted. :( http://cr.openjdk.java.net/~henryjen/tl/8024500/0/webrev/ Thanks for reviewing. A minor comment but you might want to double check SingletonIterator.java as it looks a bit misaligned (might be tabs,

Re: RFR: 8024500: Missing API coverage for java.util.function.BiFunction andThen

2013-09-11 Thread Henry Jen
Yes, the alignment is off, will fix. Cheers, Henry On Sep 11, 2013, at 7:36 AM, Alan Bateman alan.bate...@oracle.com wrote: On 11/09/2013 06:03, Henry Jen wrote: Sorry I forgot it again. Copied but not pasted. :( http://cr.openjdk.java.net/~henryjen/tl/8024500/0/webrev/ Thanks for

Re: RFR: 8024500: Missing API coverage for java.util.function.BiFunction andThen

2013-09-11 Thread Henry Jen
Thanks, it should be deliver. I'll fix before push it. Cheers, Henry On Sep 10, 2013, at 10:19 PM, Mike Duigou mike.dui...@oracle.com wrote: Tests look fine. In the BiFunction test the unknown word delieve is used. I am not sure what word was intended. Mike On Sep 10 2013, at 22:03

RFR: 8024500: Missing API coverage for java.util.function.BiFunction andThen

2013-09-10 Thread Henry Jen
Hi, Please review a simple webrev that adds two tests, one for java.util.function.BiFunction.andThen() another to cover java.util.Collections.SingletonIterator. Cheers, Henry

Re: RFR: 8024500: Missing API coverage for java.util.function.BiFunction andThen

2013-09-10 Thread Henry Jen
Sorry I forgot it again. Copied but not pasted. :( http://cr.openjdk.java.net/~henryjen/tl/8024500/0/webrev/ Thanks for reviewing. Cheers, Henry On Sep 10, 2013, at 8:47 PM, Henry Jen henry@oracle.com wrote: Hi, Please review a simple webrev that adds two tests, one for