Re: RFR: 8034944: (process) Improve subprocess handling on Solaris

2014-03-24 Thread roger riggs
Hi Rob, Martin, et.al. I've prototyped (for 9) a thread reaper[1] that uses a single thread to wait for exiting processes and calling back to the process with the exit status. the interesting part is getting the exit status back to the Process that needs it It needs more testing and

Re: RFR: 8034944: (process) Improve subprocess handling on Solaris

2014-03-23 Thread Alan Bateman
On 22/03/2014 23:47, Peter Levart wrote: : I took an exercise in re-factoring to see what it would take to merge all 4 files into one. There is a long standing bug proposing that the implementations be merged (Martin will remember some of the history on this). I would prefer that we keep

Re: RFR: 8034944: (process) Improve subprocess handling on Solaris

2014-03-23 Thread Rob McKenna
Hi folks, Roger Riggs (cc'd) may want to chip in here as he's looking at the reaper thread arrangement in 9 at the moment. On another note, I too support the merging of those files. I didn't think there was much appetite for it at the time so I must admit this fell down my todo list.

RFR: 8034944: (process) Improve subprocess handling on Solaris

2014-03-21 Thread Rob McKenna
Hi folks, I'd like to push this change into JDK8 7. There is other work going on in 9 which will supersede this fix so there is likely no point in pushing to that release. This is backport of the threadpool specific changes from https://bugs.openjdk.java.net/browse/JDK-6944584 along with

Re: RFR: 8034944: (process) Improve subprocess handling on Solaris

2014-03-21 Thread Rob McKenna
..just realised I had an out of date webrev up there, I've just updated in place in case anyone is looking at it. -Rob On 21/03/14 17:43, Rob McKenna wrote: Hi folks, I'd like to push this change into JDK8 7. There is other work going on in 9 which will supersede this fix so there is

Re: RFR: 8034944: (process) Improve subprocess handling on Solaris

2014-03-21 Thread Rob McKenna
Just when I thought I beat you to it Martin. :) On 21/03/14 18:32, Martin Buchholz wrote: OK, latest webrev looks much smaller, and appears to have only a port of changes from my changes to Linux from a few years ago. (please confirm). If so, Looks Good To Me. Yup, everything that is in

Re: RFR: 8034944: (process) Improve subprocess handling on Solaris

2014-03-21 Thread Alan Bateman
On 21/03/2014 17:43, Rob McKenna wrote: : In a nutshell a new process reaper thread was spawned for every Process created by the JDK. This fix runs these reaper threads in a thread pool to save on thread creation when creating a lot of new processes.