Hi,
> On 27 nov 2014, at 20:21, Martin Buchholz wrote:
>
> Approved! Making fields final is super-safe.
>
I agree. All fields are private (or package private for Label) so this is safe.
+1
cheers
/Joel
> On Wed, Nov 26, 2014 at 10:59 PM, Ivan Gerasimov
> wrote:
>> Hi!
>>
>> I can take car
Approved! Making fields final is super-safe.
On Wed, Nov 26, 2014 at 10:59 PM, Ivan Gerasimov
wrote:
> Hi!
>
> I can take care of jdk8 backport too, if you want.
> I've checked it, and the port seemed quite straight-forward (modulo
> unshuffling).
>
> Only changes to a few files [1] had to be ski
Hi!
I can take care of jdk8 backport too, if you want.
I've checked it, and the port seemed quite straight-forward (modulo
unshuffling).
Only changes to a few files [1] had to be skipped, as the changes appear
to already be there in jdk8u.
Here's the webrev of jdk8u backport for JDK-8062771
Hi Peter,
Yes, please file a separate issue and a RFR.
cheers
/Joel
On 10 nov 2014, at 17:13, Peter Levart wrote:
> On 11/07/2014 11:48 PM, Martin Buchholz wrote:
>> Hi Joel,
>>
>> Thanks for volunteering. I foisted all I have in
>>
>> https://bugs.openjdk.java.net/browse/JDK-8064391
>>
>>
Hi Martin,
Since you have already provided us with the patch here:
http://cr.openjdk.java.net/~martin/webrevs/openjdk8/Class-thread-safety/
Lets do it the other way around. I think this is a very good fix for 8u,
reviewed.
I'll start the backporting approval with you as the provider of the fix
a
On 11/07/2014 11:48 PM, Martin Buchholz wrote:
Hi Joel,
Thanks for volunteering. I foisted all I have in
https://bugs.openjdk.java.net/browse/JDK-8064391
I volunteer to be your reviewer for the backports.
Hi Martin,
Sorry I haven't checked this earlier, but there are still some data
races
That would be great
cheers
/Joel
On 2014-11-09, Ivan Gerasimov wrote:
> Hi!
>
> I think I can handle the backport to jdk7, if you still need a volunteer.
>
> Sincerely yours,
> Ivan
>
> On 08.11.2014 1:48, Martin Buchholz wrote:
> >Hi Joel,
> >
> >Thanks for volunteering. I foisted all I have
Hi!
I think I can handle the backport to jdk7, if you still need a volunteer.
Sincerely yours,
Ivan
On 08.11.2014 1:48, Martin Buchholz wrote:
Hi Joel,
Thanks for volunteering. I foisted all I have in
https://bugs.openjdk.java.net/browse/JDK-8064391
I volunteer to be your reviewer for the
Hi Joel,
Thanks for volunteering. I foisted all I have in
https://bugs.openjdk.java.net/browse/JDK-8064391
I volunteer to be your reviewer for the backports.
On Fri, Nov 7, 2014 at 1:36 PM, Joel Borggrén-Franck
wrote:
> Hi Martin,
>
> Thanks for the clarification.
>
> On 6 nov 2014, at 20:51,
Hi Martin,
Thanks for the clarification.
On 6 nov 2014, at 20:51, Martin Buchholz wrote:
> Hi Joel,
>
> On Thu, Nov 6, 2014 at 2:48 AM, Joel Borggrén-Franck
> wrote:
>> Hi,
>>
>> I’m having a hard time following this thread, which webrev has been updated,
>> for which release, fixing which
Hi Joel,
On Thu, Nov 6, 2014 at 2:48 AM, Joel Borggrén-Franck
wrote:
> Hi,
>
> I’m having a hard time following this thread, which webrev has been updated,
> for which release, fixing which issue?
I am submitting the changeset for JDK-8062771, adding the finals and
the (failed reproduction) tes
Hi,
I’m having a hard time following this thread, which webrev has been updated,
for which release, fixing which issue?
Martin, as far as I can see you are the only one of us who has replied to this
thread who is a jdk7u committer (or reviewer).
I think the assumption is that generic repositor
On Nov 4, 2014, at 6:53 PM, Martin Buchholz wrote:
>> Is it possible to make EmptyClass be a static inner class of the test? IIUC
>> if its enclosed within ThreadSafety it should still work with URLClassLoader.
>
> Done. Webrev regenerated.
+1
Perhaps one reason why the test is not failing (o
Hi Martin,
On 04.11.2014 23:11, Martin Buchholz wrote:
> On Tue, Nov 4, 2014 at 11:55 AM, Aleksey Shipilev
> wrote:
>> On 04.11.2014 20:53, Martin Buchholz wrote:
>>> On Tue, Nov 4, 2014 at 2:13 AM, Paul Sandoz wrote:
On Nov 3, 2014, at 11:18 PM, Martin Buchholz wrote:
>> If you do this:
>
Hi Aleksey,
On Tue, Nov 4, 2014 at 11:55 AM, Aleksey Shipilev
wrote:
> On 04.11.2014 20:53, Martin Buchholz wrote:
>> On Tue, Nov 4, 2014 at 2:13 AM, Paul Sandoz wrote:
>>> On Nov 3, 2014, at 11:18 PM, Martin Buchholz wrote:
> If you do this:
>
>> // Generic info repository; lazily initial
On 04.11.2014 20:53, Martin Buchholz wrote:
> On Tue, Nov 4, 2014 at 2:13 AM, Paul Sandoz wrote:
>> On Nov 3, 2014, at 11:18 PM, Martin Buchholz wrote:
>>> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/reflection-final-fields/
>>> https://bugs.openjdk.java.net/browse/JDK-8062771
Looks good
[+core-libs-dev, Alexey]
On Tue, Nov 4, 2014 at 2:13 AM, Paul Sandoz wrote:
> Hi Martin,
>
> Should this and the other review also be posted on core-libs?
(sorry for forgetting the mailing list)
> On Nov 3, 2014, at 11:18 PM, Martin Buchholz wrote:
>
>> Hi Joe, Paul,
>>
>> I'd like you to do
17 matches
Mail list logo
