Re: RFR: 8147607: Remove test library dependency on sun.security.tools.jarsigner.Main

2016-01-28 Thread Steve Drach
>>> Shouldn't you also include the FileOuputStream in try-with-resources? >> >> It is. Do you need to refresh your browers? > > If you read the code quickly, I missed it too, maybe it would be better to > put the opening brace on a separate line, i.e.: > > try (ZipFile in = new ZipFile("multi-r

Re: RFR: 8147607: Remove test library dependency on sun.security.tools.jarsigner.Main

2016-01-28 Thread Sean Mullan
On 01/28/2016 10:17 AM, Chris Hegarty wrote: On 28 Jan 2016, at 15:16, Wang Weijun wrote: Shouldn't you also include the FileOuputStream in try-with-resources? It is. Do you need to refresh your browers? If you read the code quickly, I missed it too, maybe it would be better to put the op

Re: RFR: 8147607: Remove test library dependency on sun.security.tools.jarsigner.Main

2016-01-28 Thread Chris Hegarty
On 28 Jan 2016, at 15:16, Wang Weijun wrote: > Shouldn't you also include the FileOuputStream in try-with-resources? It is. Do you need to refresh your browers? -Chris. > --Max > >> On Jan 28, 2016, at 5:32 PM, Chris Hegarty wrote: >> >> >> On 28 Jan 2016, at 00:35, Steve Drach wrote: >>

Re: RFR: 8147607: Remove test library dependency on sun.security.tools.jarsigner.Main

2016-01-28 Thread Wang Weijun
Shouldn't you also include the FileOuputStream in try-with-resources? --Max > On Jan 28, 2016, at 5:32 PM, Chris Hegarty wrote: > > > On 28 Jan 2016, at 00:35, Steve Drach wrote: > >> Please review a small change to the zipfs test library. >> >> Issue: https://bugs.openjdk.java.net/browse/J

Re: RFR: 8147607: Remove test library dependency on sun.security.tools.jarsigner.Main

2016-01-28 Thread Chris Hegarty
On 28 Jan 2016, at 00:35, Steve Drach wrote: > Please review a small change to the zipfs test library. > > Issue: https://bugs.openjdk.java.net/browse/JDK-8147607 > Webrev: http://cr.openjdk.java.net/~sdrach/8147607/webrev > > This change uses the public jdk.security.jarsigner.JarSigner API ra

Re: RFR: 8147607: Remove test library dependency on sun.security.tools.jarsigner.Main

2016-01-28 Thread Paul Sandoz
> On 28 Jan 2016, at 01:35, Steve Drach wrote: > > Please review a small change to the zipfs test library. > > Issue: https://bugs.openjdk.java.net/browse/JDK-8147607 > > Webrev: http://cr.openjdk.java.net/~sdrach/8147607/webrev >

RFR: 8147607: Remove test library dependency on sun.security.tools.jarsigner.Main

2016-01-27 Thread Steve Drach
Please review a small change to the zipfs test library. Issue: https://bugs.openjdk.java.net/browse/JDK-8147607 Webrev: http://cr.openjdk.java.net/~sdrach/8147607/webrev This change uses the p