Re: RFR: 8152074: Avoid lambda usage in StringConcatFactory initializer

2016-03-19 Thread Aleksey Shipilev
On 17.03.2016 09:50, Claes Redestad wrote: > please review this patch to remove lambda usage in the > StringConcatFactory initializer, which saves some parts of > java.lang.invoke infrastructure initialization for later. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8152074 > Webrev: http://cr

RFR: 8152074: Avoid lambda usage in StringConcatFactory initializer

2016-03-19 Thread Claes Redestad
Hi, please review this patch to remove lambda usage in the StringConcatFactory initializer, which saves some parts of java.lang.invoke infrastructure initialization for later. Bug: https://bugs.openjdk.java.net/browse/JDK-8152074 Webrev: http://cr.openjdk.java.net/~redestad/8152074/webrev.01/

Re: RFR: 8152074: Avoid lambda usage in StringConcatFactory initializer

2016-03-19 Thread Chris Hegarty
> On 17 Mar 2016, at 07:10, Claes Redestad wrote: > > On 2016-03-17 08:05, Aleksey Shipilev wrote: >> On 17.03.2016 09:50, Claes Redestad wrote: >>> please review this patch to remove lambda usage in the >>> StringConcatFactory initializer, which saves some parts of >>> java.lang.invoke infrastr

Re: RFR: 8152074: Avoid lambda usage in StringConcatFactory initializer

2016-03-19 Thread Aleksey Shipilev
On 17.03.2016 10:10, Claes Redestad wrote: > On 2016-03-17 08:05, Aleksey Shipilev wrote: >> Is there any performance benefit in keeping the single PrivilegedBlock >> though? I.e. convert the lambda to anonymous class, and be done with it? > > I haven't measured it thoroughly, but I've noticed ano

Re: RFR: 8152074: Avoid lambda usage in StringConcatFactory initializer

2016-03-19 Thread Claes Redestad
Thanks Rémi, Aleksey and Chris for reviewing, since this might help with intermittent test timeouts in hs-nightly, I've received an offline request to push this via jdk9/hs-rt, which I'll do unless anyone objects. /Claes On 2016-03-17 10:04, Chris Hegarty wrote: On 17 Mar 2016, at 07:10, Cl

Re: RFR: 8152074: Avoid lambda usage in StringConcatFactory initializer

2016-03-19 Thread Claes Redestad
On 2016-03-17 08:05, Aleksey Shipilev wrote: On 17.03.2016 09:50, Claes Redestad wrote: please review this patch to remove lambda usage in the StringConcatFactory initializer, which saves some parts of java.lang.invoke infrastructure initialization for later. Bug: https://bugs.openjdk.java.ne

Re: RFR: 8152074: Avoid lambda usage in StringConcatFactory initializer

2016-03-18 Thread Remi Forax
ginal - > De: "Claes Redestad" > À: "Aleksey Shipilev" , "core-libs-dev Libs" > > Envoyé: Jeudi 17 Mars 2016 08:10:49 > Objet: Re: RFR: 8152074: Avoid lambda usage in StringConcatFactory > initializer > > > > On 2016-03-17 08:05