Re: RFR: 8166026: refactor shell tests to java [v3]

2021-01-05 Thread Roger Riggs
On Thu, 3 Dec 2020 21:41:58 GMT, Roger Riggs wrote: >> Ivan Šipka has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8166026: Refactor java/lang shell tests to java > > Marked as reviewed by rriggs (Reviewer). Some update is needed before

Re: RFR: 8166026: refactor shell tests to java [v3]

2020-12-03 Thread Roger Riggs
On Thu, 3 Dec 2020 19:46:14 GMT, Ivan Šipka wrote: >> @iignatev could you please review? Thank you. >> >> note to self: >> jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java >> test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java >>

Re: RFR: 8166026: refactor shell tests to java [v3]

2020-12-03 Thread Ivan Šipka
> @iignatev could you please review? Thank you. > > note to self: > jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java > test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java > test/jdk/java/lang/Thread/uncaughtexceptions/UncaughtExceptionsTest.java >

Re: RFR: 8166026: refactor shell tests to java [v2]

2020-12-02 Thread Ivan Šipka
On Mon, 30 Nov 2020 17:44:13 GMT, Roger Riggs wrote: >> Ivan Šipka has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits

Re: RFR: 8166026: refactor shell tests to java [v2]

2020-12-02 Thread Ivan Šipka
> @iignatev could you please review? Thank you. > > note to self: > jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java > test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java > test/jdk/java/lang/Thread/uncaughtexceptions/UncaughtExceptionsTest.java >

Re: RFR: 8166026: refactor shell tests to java

2020-12-02 Thread Ivan Šipka
On Mon, 30 Nov 2020 17:53:07 GMT, Roger Riggs wrote: >> @iignatev could you please review? Thank you. >> >> note to self: >> jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java >> test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java >>

Re: RFR: 8166026: refactor shell tests to java

2020-12-02 Thread Ivan Šipka
On Mon, 30 Nov 2020 21:32:35 GMT, Igor Ignatyev wrote: >> @iignatev could you please review? Thank you. >> >> note to self: >> jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java >> test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java >>

Re: RFR: 8166026: refactor shell tests to java

2020-12-02 Thread Ivan Šipka
On Mon, 30 Nov 2020 21:36:40 GMT, Igor Ignatyev wrote: >> @iignatev could you please review? Thank you. >> >> note to self: >> jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java >> test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java >>

Re: RFR: 8166026: refactor shell tests to java

2020-11-30 Thread Igor Ignatyev
On Fri, 27 Nov 2020 18:50:19 GMT, Ivan Šipka wrote: > @iignatev could you please review? Thank you. > > note to self: > jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java > test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java >

Re: RFR: 8166026: refactor shell tests to java

2020-11-30 Thread Roger Riggs
On Fri, 27 Nov 2020 18:50:19 GMT, Ivan Šipka wrote: > @iignatev could you please review? Thank you. > > note to self: > jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java > test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java >

RFR: 8166026: refactor shell tests to java

2020-11-27 Thread Ivan Šipka
@iignatev could you please review? Thank you. note to self: jtreg test/jdk/java/lang/ProcessBuilder/InheritIO/InheritIoTest.java test/jdk/java/lang/SecurityManager/modules/CustomSecurityManagerTest.java test/jdk/java/lang/Thread/uncaughtexceptions/UncaughtExceptionsTest.java