RE: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE

2016-11-23 Thread Langer, Christoph
lt;mailto:christoph.lan...@sap.com> Cc: core-libs-dev@openjdk.java.net<mailto:core-libs-dev@openjdk.java.net> Subject: Re: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE On 11/18/16, 12:17 PM, Langer, Christoph wrote: Hi Joe, Yep, I'll conduct the

Re: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE

2016-11-22 Thread Joe Wang
ev@openjdk.java.net <mailto:core-libs-dev@openjdk.java.net> *Subject:* Re: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE Looks good, Christoph. I assume you'll do an all-test run (all in jaxp/test) before pushing. No nee

RE: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE

2016-11-22 Thread Langer, Christoph
m] Sent: Samstag, 19. November 2016 00:23 To: Langer, Christoph Cc: core-libs-dev@openjdk.java.net Subject: Re: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE On 11/18/16, 12:17 PM, Langer, Christoph wrote: Hi Joe, Yep, I'll conduct the testing

Re: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE

2016-11-18 Thread Joe Wang
hristoph *From:*Joe Wang [mailto:huizhe.w...@oracle.com] *Sent:* Freitag, 18. November 2016 20:00 *To:* Langer, Christoph *Cc:* core-libs-dev@openjdk.java.net *Subject:* Re: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE Looks good, Christoph. I assume y

RE: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE

2016-11-18 Thread Langer, Christoph
penjdk.java.net Subject: Re: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE Looks good, Christoph. I assume you'll do an all-test run (all in jaxp/test) before pushing. No need for further review, but it'd be nice to add an "Expe

Re: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE

2016-11-18 Thread Joe Wang
Christoph *Cc:* core-libs-dev@openjdk.java.net *Subject:* Re: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE Looks fine. License header: in general, don't change / add Year if there's no material change, removing the legacy $Id field in Em

RE: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE

2016-11-18 Thread Langer, Christoph
ation of DOM with null valued text node causes NPE Looks fine. License header: in general, don't change / add Year if there's no material change, removing the legacy $Id field in EmptySerializer.java for example, does not constitute a change to the code, so just keep the origin

Re: RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE

2016-11-17 Thread Joe Wang
Looks fine. License header: in general, don't change / add Year if there's no material change, removing the legacy $Id field in EmptySerializer.java for example, does not constitute a change to the code, so just keep the original year (see below). The initial years for the classes:

RFR: 8169772: [JAXP] XALAN: Transformation of DOM with null valued text node causes NPE

2016-11-16 Thread Langer, Christoph
Hi, please review another XALAN fix. The Serializer should be able to handle text nodes with null input. There has already been some discussion here: http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-November/044567.html Bug: https://bugs.openjdk.java.net/browse/JDK-8169772 Webrev: htt