Re: RFR: 8179370: Replace use of , and tags in java.base

Only comment is updating the copyright dates to 2017. Brad On 4/26/2017 6:23 PM, Mandy Chung wrote: Looks okay. Mandy On Apr 26, 2017, at 5:50 PM, Jonathan Gibbons wrote: Please review these mostly simple changes to replace HTML tags which are not valid in

Re: RFR: 8179370: Replace use of , and tags in java.base

> On Apr 26, 2017, at 6:49 PM, Jonathan Gibbons > wrote: > > Updated webrev to address Joe's suggestion to try harder to use {@code} as a > substitute for . > > http://cr.openjdk.java.net/~jjg/8179370/webrev.01 Looks good. Mandy

Re: RFR: 8179370: Replace use of , and tags in java.base

On 27/04/2017 02:49, Jonathan Gibbons wrote: Updated webrev to address Joe's suggestion to try harder to use {@code} as a substitute for . http://cr.openjdk.java.net/~jjg/8179370/webrev.01 The updated version using {@code ... } looks better and also keeps the lines from growing too long.

Re: RFR: 8179370: Replace use of , and tags in java.base

Looks better; thanks Jon, -Joe On 4/26/2017 6:49 PM, Jonathan Gibbons wrote: Updated webrev to address Joe's suggestion to try harder to use {@code} as a substitute for . http://cr.openjdk.java.net/~jjg/8179370/webrev.01 The modified sed script has a new first line: s|\([^&<>]*\)|{@code

Re: RFR: 8179370: Replace use of , and tags in java.base

Updated webrev to address Joe's suggestion to try harder to use {@code} as a substitute for . http://cr.openjdk.java.net/~jjg/8179370/webrev.01 The modified sed script has a new first line: s|\([^&<>]*\)|{@code \1}|g s|||g s|||g s|<\\/tt>|<\\/code>|g s|\(]*\)>\([^<]*\)|\1

Re: RFR: 8179370: Replace use of , and tags in java.base

Looks okay. Mandy > On Apr 26, 2017, at 5:50 PM, Jonathan Gibbons > wrote: > > Please review these mostly simple changes to replace HTML tags which are not > valid in HTML 5 in public doc comments in java.base. > > As with the previous changes, the changes were

Re: RFR: 8179370: Replace use of , and tags in java.base

Joe, Yes, there are occurrences here that require instead of {@code}, because of the presence of HTML entities. It's about 50/50. I'd prefer to stay with mechanical updates as much as possible for these bulk updates, as compared to manual updates, but I may be able to improve the sed

Re: RFR: 8179370: Replace use of , and tags in java.base

Hi Jon, I'd prefer if the "foo" were replaced with "{@code tt}" rather than "foo"- none of the tricky cases which preclude use of {@code } use seem to be present here - but will approve the changeset in its current form too. Cheers, -Joe On 4/26/2017 5:50 PM, Jonathan Gibbons wrote:

RFR: 8179370: Replace use of , and tags in java.base

Please review these mostly simple changes to replace HTML tags which are not valid in HTML 5 in public doc comments in java.base. As with the previous changes, the changes were done mechanically, using the following sed script: s|||g s|||g s|<\\/tt>|<\\/code>|g s|\(]*\)>\([^<]*\)|\1