Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

2017-07-10 Thread Jonathan Gibbons
Thanks. I see the ERROR. I'm not sure of the reasoning why your fix works: maybe because the data cell is empty, it doesn't need headers. I'll do more experiments! Anyway, I'm happy to go with the suggested fix. -- Jon On 07/10/2017 05:40 PM, huizhe wang wrote: That looks great! Almost a

Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

2017-07-10 Thread huizhe wang
That looks great! Almost all "green"! The only exception is the table in javax/xml/validation/Validator.java where the empty cell resulted in a reported "ERROR". I tried changing to and saw that the tool happily accepted it: - 138 * + 138 * If you decide to adopt the above

Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

2017-07-10 Thread Jonathan Gibbons
Here is the amended webrev for the work on fixing the tables (and other nits) in the jaxp docs. As we discussed, I changed the two manually edited tables, in CatalogFeatures and XMLStreamWriter, to use scope=row/col. There are now no tables in the jaxp repo using headers to identify row and c

Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

2017-07-10 Thread huizhe wang
Jon, Glad to know that works out. Hopefully this exercise with the jaxp repo can be a bit helpful to your effort and utility. Thanks for using the jaxp repo for this exercise! Best, Joe On 7/8/2017 9:58 AM, Jonathan Gibbons wrote: Joe, Thanks for the feedback. I've done some experiments

Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

2017-07-08 Thread Jonathan Gibbons
Joe, Thanks for the feedback. I've done some experiments and it looks like we can indeed simplify the more complex tables to always use scope=row|col. I'll post an amended webrev next week. Thanks for the feedback and suggestion to revisit this issue. -- Jon On 7/7/17 5:50 PM, huizhe wang

Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

2017-07-07 Thread Jonathan Gibbons
On 7/7/17 5:50 PM, huizhe wang wrote: Hi Jon, For the table in CatalogFeatures, the id attribute for Type and Value are not used, may be unnecessary. Instead, scope="col" can be added, is that right? 50 * Type 51 * Value I'm new to accessibility, but it seems to me the following can use s

Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

2017-07-07 Thread huizhe wang
Hi Jon, For the table in CatalogFeatures, the id attribute for Type and Value are not used, may be unnecessary. Instead, scope="col" can be added, is that right? 50 * Type 51 * Value I'm new to accessibility, but it seems to me the following can use scope="colgroup" instead? 46 * Value [

Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

2017-07-07 Thread Jonathan Gibbons
Sorry, I meant to include that; will post shortly, beside the webrev. -- Jon On 07/07/2017 01:33 PM, Lance Andersen wrote: Hi Jon, The changes looked good to me. Is the html available by chance to do an extra sanity check? Best Lance On Jul 7, 2017, at 2:14 PM, Jonathan Gibbons mailto:jo

Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

2017-07-07 Thread Lance Andersen
Hi Jon, The changes looked good to me. Is the html available by chance to do an extra sanity check? Best Lance > On Jul 7, 2017, at 2:14 PM, Jonathan Gibbons > wrote: > > Please review the following fixes to the doc comments in the jaxp repo. > > The primary goal is to fix user-written tab

RFR: 8184021: Fix tables in jaxp doc comments to be accessible

2017-07-07 Thread Jonathan Gibbons
Please review the following fixes to the doc comments in the jaxp repo. The primary goal is to fix user-written tables in doc comments for accessibility, either by updating tables to use scope=row|col in header cells for simple tables, or by using the headings attribute in more complex tables.