Re: RFR: 8188066: (ref) Examine the reachability of JNI WeakGlobalRef and interaction with phantom refs

2019-03-18 Thread Kim Barrett
> On Mar 14, 2019, at 12:40 AM, David Holmes wrote: > > Looks good. > > Thanks Kim! > > David Thanks.

Re: RFR: 8188066: (ref) Examine the reachability of JNI WeakGlobalRef and interaction with phantom refs

2019-03-13 Thread David Holmes
Looks good. Thanks Kim! David - On 14/03/2019 9:02 am, Kim Barrett wrote: On Mar 13, 2019, at 4:29 PM, Kim Barrett wrote: On Mar 13, 2019, at 4:07 PM, Kim Barrett wrote: Please review this change to the JNI specification. The specified behavior of Weak Global References, and in

Re: RFR: 8188066: (ref) Examine the reachability of JNI WeakGlobalRef and interaction with phantom refs

2019-03-13 Thread Kim Barrett
> On Mar 13, 2019, at 6:19 PM, Hans Boehm wrote: > > Looks great to me! Thanks. > Just to be clear, this is intended to guarantee that it's not possible to > promote a weak global reference that indirectly points to A after a > PhantomReference or a WeakGlobalReference to A has been cleared?

Re: RFR: 8188066: (ref) Examine the reachability of JNI WeakGlobalRef and interaction with phantom refs

2019-03-13 Thread Kim Barrett
> On Mar 13, 2019, at 5:32 PM, Per Liden wrote: > > > On 03/13/2019 09:29 PM, Kim Barrett wrote: >>> On Mar 13, 2019, at 4:07 PM, Kim Barrett wrote: >>> >>> Please review this change to the JNI specification. The specified >>> behavior of Weak Global References, and in particular their >>>

Re: RFR: 8188066: (ref) Examine the reachability of JNI WeakGlobalRef and interaction with phantom refs

2019-03-13 Thread Kim Barrett
> On Mar 13, 2019, at 5:00 PM, Mandy Chung wrote: > > > > On 3/13/19 1:29 PM, Kim Barrett wrote: >>> On Mar 13, 2019, at 4:07 PM, Kim Barrett wrote: >>> >>> Please review this change to the JNI specification. The specified >>> behavior of Weak Global References, and in particular their >>>

Re: RFR: 8188066: (ref) Examine the reachability of JNI WeakGlobalRef and interaction with phantom refs

2019-03-13 Thread Kim Barrett
> On Mar 13, 2019, at 4:29 PM, Kim Barrett wrote: > >> On Mar 13, 2019, at 4:07 PM, Kim Barrett wrote: >> >> Please review this change to the JNI specification. The specified >> behavior of Weak Global References, and in particular their >> relationship to Java PhantomReference, is being

Re: RFR: 8188066: (ref) Examine the reachability of JNI WeakGlobalRef and interaction with phantom refs

2019-03-13 Thread Hans Boehm
Looks great to me! Just to be clear, this is intended to guarantee that it's not possible to promote a weak global reference that indirectly points to A after a PhantomReference or a WeakGlobalReference to A has been cleared? Thus this reference clearing must happen more or less atomically. I

Re: RFR: 8188066: (ref) Examine the reachability of JNI WeakGlobalRef and interaction with phantom refs

2019-03-13 Thread Per Liden
On 03/13/2019 09:29 PM, Kim Barrett wrote: On Mar 13, 2019, at 4:07 PM, Kim Barrett wrote: Please review this change to the JNI specification. The specified behavior of Weak Global References, and in particular their relationship to Java PhantomReference, is being updated to account for a

Re: RFR: 8188066: (ref) Examine the reachability of JNI WeakGlobalRef and interaction with phantom refs

2019-03-13 Thread Mandy Chung
On 3/13/19 1:29 PM, Kim Barrett wrote: On Mar 13, 2019, at 4:07 PM, Kim Barrett wrote: Please review this change to the JNI specification. The specified behavior of Weak Global References, and in particular their relationship to Java PhantomReference, is being updated to account for a

Re: RFR: 8188066: (ref) Examine the reachability of JNI WeakGlobalRef and interaction with phantom refs

2019-03-13 Thread Kim Barrett
> On Mar 13, 2019, at 4:07 PM, Kim Barrett wrote: > > Please review this change to the JNI specification. The specified > behavior of Weak Global References, and in particular their > relationship to Java PhantomReference, is being updated to account > for a change to PhantomReference by

RFR: 8188066: (ref) Examine the reachability of JNI WeakGlobalRef and interaction with phantom refs

2019-03-13 Thread Kim Barrett
Please review this change to the JNI specification. The specified behavior of Weak Global References, and in particular their relationship to Java PhantomReference, is being updated to account for a change to PhantomReference by JDK-8071507. CR: https://bugs.openjdk.java.net/browse/JDK-8188066