Re: RFR: 8193660 Check SOURCE line in "release" file for closedjdk

2018-02-28 Thread Randy Crihfield
On 02/28/18 11:58 AM, Alan Bateman wrote: On 28/02/2018 16:57, Randy Crihfield wrote: poke poke can someone please review? Thanks The `release` is a properties file so I assume you can simplify the test by using Properties.load and then testing if the "SOURCE" key is present and whether

Re: RFR: 8193660 Check SOURCE line in "release" file for closedjdk

2018-02-28 Thread Alan Bateman
On 28/02/2018 16:57, Randy Crihfield wrote: poke poke can someone please review?  Thanks The `release` is a properties file so I assume you can simplify the test by using Properties.load and then testing if the "SOURCE" key is present and whether it has the expected value. -Alan.

Re: RFR: 8193660 Check SOURCE line in "release" file for closedjdk

2018-02-28 Thread Randy Crihfield
poke poke can someone please review? Thanks Randy On 02/15/18 12:25 PM, Randy Crihfield wrote: I need to revise the resource file test created for JDK-8192837 The new bug is https://bugs.openjdk.java.net/browse/JDK-8193660 The webrev is located at

RFR: 8193660 Check SOURCE line in "release" file for closedjdk

2018-02-15 Thread Randy Crihfield
I need to revise the resource file test created for JDK-8192837 The new bug is https://bugs.openjdk.java.net/browse/JDK-8193660 The webrev is located at http://cr.openjdk.java.net/~shurailine/8193660/webrev.00/ Any