Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-07-21 Thread Ian Graves
On Wed, 21 Jul 2021 21:30:01 GMT, Lance Andersen wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> delete errant line > > src/java.base/share/classes/java/util/regex/Pattern.java line 758: > >> 756: *group just

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-07-21 Thread Ian Graves
On Wed, 21 Jul 2021 20:22:04 GMT, Pavel Rappo wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> delete errant line > > src/java.base/share/classes/java/util/regex/Pattern.java line 833: > >> 831: * Comments

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-07-21 Thread Lance Andersen
On Wed, 21 Jul 2021 21:25:18 GMT, Ian Graves wrote: >> 8199594: Add doc describing how (?x) ignores spaces in character classes > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > delete errant line

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-07-21 Thread Ian Graves
> 8199594: Add doc describing how (?x) ignores spaces in character classes Ian Graves has updated the pull request incrementally with one additional commit since the last revision: delete errant line - Changes: - all: https://git.openjdk.java.net/jdk/pull/4618/files - new:

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-04-21 Thread Ian Graves
On Wed, 21 Apr 2021 02:56:12 GMT, Stuart Marks wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding differences to Perl 5 note > > A few minor wording adjustments. Please update the CSR accordingly and I'll >

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-04-20 Thread Stuart Marks
On Mon, 19 Apr 2021 22:12:30 GMT, Ian Graves wrote: >> Clarifying note on comments mode to explicitly note that whitespace within >> character classes is ignored. > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Adding

Re: RFR: 8199594: Add doc describing how (?x) ignores spaces in character classes [v2]

2021-04-19 Thread Ian Graves
> Clarifying note on comments mode to explicitly note that whitespace within > character classes is ignored. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Adding differences to Perl 5 note - Changes: - all: