Re: RFR: 8203359: Container level resources events [v9]

2021-05-20 Thread Jaroslav Bachorik
On Wed, 19 May 2021 17:21:26 GMT, Erik Gahlin wrote: > I think you need to add the hook, for the event metadata to be correct. > Otherwise, the "period" setting will not show up. Yes. The failed test log would indicate also the rest of the metadata not being in a good shape. But with the hook

Re: RFR: 8203359: Container level resources events [v9]

2021-05-19 Thread Erik Gahlin
On Wed, 21 Apr 2021 22:38:32 GMT, Erik Gahlin wrote: >> Jaroslav Bachorik has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. > > I wonder if something similar to

Re: RFR: 8203359: Container level resources events [v9]

2021-05-19 Thread Jaroslav Bachorik
On Wed, 21 Apr 2021 22:38:32 GMT, Erik Gahlin wrote: >> Jaroslav Bachorik has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. > > I wonder if something similar to

Re: RFR: 8203359: Container level resources events [v9]

2021-04-27 Thread Severin Gehwolf
On Thu, 22 Apr 2021 15:08:59 GMT, Jaroslav Bachorik wrote: >> I wonder if something similar to below could be added to >> jdk.jfr.internal.Utils: >> >> private static Metrics[] metrics; >> public static Metrics getMetrics() { >> if (metrics == null) { >> metrics =

Re: RFR: 8203359: Container level resources events [v9]

2021-04-27 Thread Severin Gehwolf
On Thu, 22 Apr 2021 15:08:59 GMT, Jaroslav Bachorik wrote: >> I wonder if something similar to below could be added to >> jdk.jfr.internal.Utils: >> >> private static Metrics[] metrics; >> public static Metrics getMetrics() { >> if (metrics == null) { >> metrics =

Re: RFR: 8203359: Container level resources events [v9]

2021-04-22 Thread Jaroslav Bachorik
On Wed, 21 Apr 2021 22:38:32 GMT, Erik Gahlin wrote: >> Jaroslav Bachorik has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix event metadata > > I wonder if something similar to below could be added to > jdk.jfr.internal.Utils: > >

Re: RFR: 8203359: Container level resources events [v9]

2021-04-21 Thread Erik Gahlin
On Wed, 21 Apr 2021 13:34:28 GMT, Jaroslav Bachorik wrote: >> With this change it becomes possible to surface various cgroup level metrics >> (available via `jdk.internal.platform.Metrics`) as JFR events. >> >> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is >>

Re: RFR: 8203359: Container level resources events [v9]

2021-04-21 Thread Jaroslav Bachorik
> With this change it becomes possible to surface various cgroup level metrics > (available via `jdk.internal.platform.Metrics`) as JFR events. > > Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is > turned into JFR events to start with. > * CPU related metrics > *