Re: RFR: 8205184: Delegating Iterator implementations that don't delegate forEachRemaining()

2018-06-25 Thread Martin Buchholz
Committed.

Re: RFR: 8205184: Delegating Iterator implementations that don't delegate forEachRemaining()

2018-06-25 Thread Martin Buchholz
On Mon, Jun 25, 2018 at 11:17 AM, Paul Sandoz wrote: > Looks good. Sometimes in these cases i reach for proxy rather than > explicit code. It tends to be more robust to certain changes at the expense > of reflective complexity. > > Hmmm ... Never done that in a test before. > You could

Re: RFR: 8205184: Delegating Iterator implementations that don't delegate forEachRemaining()

2018-06-25 Thread Paul Sandoz
Looks good. Sometimes in these cases i reach for proxy rather than explicit code. It tends to be more robust to certain changes at the expense of reflective complexity. You could probably reduce the test method names by removing the “forEachRemainingIsDelegated_” given that can be inferred

RFR: 8205184: Delegating Iterator implementations that don't delegate forEachRemaining()

2018-06-21 Thread Martin Buchholz
8205184: Delegating Iterator implementations that don't delegate forEachRemaining() http://cr.openjdk.java.net/~martin/webrevs/jdk/delegate-forEachRemaining/ https://bugs.openjdk.java.net/browse/JDK-8205184