Re: RFR: 8211990: DateTimeException thrown when calculating duration between certain dates

+1 on the bug fix. (I wouldn't spend time changing a bunch of tests that have a consistent style of their own. Having a few that look different is inconsistent and 'wrong'.  And I wouldn't fix even one of them. No one is mechanically looking for @summary in these tests and its just make-work.)

Re: RFR: 8211990: DateTimeException thrown when calculating duration between certain dates

Hi Naoto, Thank you for adding the heading. you rock :-) > On Aug 13, 2019, at 11:06 AM, naoto.s...@oracle.com wrote: > > Hi Lance, > > I modified the headers of those two test cases as follows: > > http://cr.openjdk.java.net/~naoto/8211990/webrev.01/ > > Didn't bother changing others :-) >

Re: RFR: 8211990: DateTimeException thrown when calculating duration between certain dates

Hi Lance, I modified the headers of those two test cases as follows: http://cr.openjdk.java.net/~naoto/8211990/webrev.01/ Didn't bother changing others :-) Naoto On 8/12/19 3:46 PM, Lance Andersen wrote: Hi Naoto On Aug 12, 2019, at 6:34 PM, naoto.s...@oracle.com

Re: RFR: 8211990: DateTimeException thrown when calculating duration between certain dates

Hi Naoto > On Aug 12, 2019, at 6:34 PM, naoto.s...@oracle.com wrote: > > Hi Lance, > > Yes, I would like the style, but AFAIK, all java.time tests are testng, and > controlled with the java/time/{test/tck}/TEST.properties file so that each > test file won't need jtreg tags (it cannot override t

Re: RFR: 8211990: DateTimeException thrown when calculating duration between certain dates

Hi Lance, Yes, I would like the style, but AFAIK, all java.time tests are testng, and controlled with the java/time/{test/tck}/TEST.properties file so that each test file won't need jtreg tags (it cannot override them either). Naoto On 8/12/19 3:17 PM, Lance Andersen wrote: Hi Naoto, On Aug

Re: RFR: 8211990: DateTimeException thrown when calculating duration between certain dates

Hi Naoto, > On Aug 12, 2019, at 6:01 PM, naoto.s...@oracle.com wrote: > > Thank you for the review, Lance. > > On 8/12/19 2:37 PM, Lance Andersen wrote: >> Looks good Naoto. >> One question I had which is not relevant to your fix, but should the tests >> as we modify them include the JTReg tags

Re: RFR: 8211990: DateTimeException thrown when calculating duration between certain dates

Thank you for the review, Lance. On 8/12/19 2:37 PM, Lance Andersen wrote: Looks good Naoto. One question I had which is not relevant to your fix, but should the tests as we modify them include the JTReg tags such as @bug, @summary…. etc…  just for consistency…. I put @bug tags to each of t

Re: RFR: 8211990: DateTimeException thrown when calculating duration between certain dates

Looks good Naoto. One question I had which is not relevant to your fix, but should the tests as we modify them include the JTReg tags such as @bug, @summary…. etc… just for consistency…. Best Lance > On Aug 12, 2019, at 4:43 PM, naoto.s...@oracle.com wrote: > > Hello, > > Please review the f

Re: RFR: 8211990: DateTimeException thrown when calculating duration between certain dates

+1 On Mon, 12 Aug 2019 at 21:44, wrote: > > Hello, > > Please review the fix to the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8211990 > > The proposed changeset is located at: > > https://cr.openjdk.java.net/~naoto/8211990/webrev.00/ > > The DateTimeException was thrown due to

RFR: 8211990: DateTimeException thrown when calculating duration between certain dates

Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8211990 The proposed changeset is located at: https://cr.openjdk.java.net/~naoto/8211990/webrev.00/ The DateTimeException was thrown due to unconditional conversion beyond the valid range of the int