Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-12-06 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.00/ IBM29626C charset is required for AIX default charset. Java cannot start because of java/lang/ExceptionInInitializerError on AIX ja_JP

Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-11-29 Thread Ichiroh Takiguchi
Hello Alan & Magnus. Sorry for you confusion. I did many copy actions and rename actions. So you may see, I added unexpected code into non AIX platform. I think I should not put 2 kind of modification. For this bug id, I'll handle IBM964 and IBM33722. (also SimpleEUCEncoder.java is required)

Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-11-28 Thread Magnus Ihse Bursie
On 2018-11-28 10:36, Alan Bateman wrote: On 28/11/2018 09:28, Magnus Ihse Bursie wrote: I'm quite unsatisfied with the current handling of character sets in the build in general. :-( I'd really like to modernize it. I have a, slightly fuzzy, laundry list of things I want to fix from a build

Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-11-28 Thread Alan Bateman
On 28/11/2018 09:28, Magnus Ihse Bursie wrote: I'm quite unsatisfied with the current handling of character sets in the build in general. :-( I'd really like to modernize it. I have a, slightly fuzzy, laundry list of things I want to fix from a build perspective, but I'm not sure of what

Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-11-28 Thread Alan Bateman
On 15/11/2018 00:29, Ichiroh Takiguchi wrote: Hello Martin. I know your point, but it's default encoding issue. User cannot start OpenJDK JDK9/10/11/12 on ja_JP(IBM29626C) and zh_TW(IBM964) locale on AIX. But IBM964 cannot be used for default encoding in current setting. This fix is really

Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-11-27 Thread Andrew Leonard
No worries Martin, I realize what you're saying about AIX, I shall put out feelers for another sponsor. Thanks Andrew Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leon...@uk.ibm.com From: Martin

Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-11-26 Thread Martin Buchholz
Sorry, I'm sympathetic but I can't help push this through. These days, all computers should have a default charset of UTF-8 or perhaps one of the other "Standard" charsets. Other charsets should be regarded as legacy. Surely AIX has UTF-8 variants of all the locales? On Sun, Nov 25, 2018 at

RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-11-25 Thread Andrew Leonard
Hi Martin, Just to add to Ichiroh's comments, if an AIX machine is configured with a default OS charset of IBM-964 or IBM-29626C, then the OpenJDK VM(Hotspot) will be unable to start as the VM initialization during the bootstrap phase will try to load the charset. Thus it must be in the

Re: Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-11-14 Thread Ichiroh Takiguchi
Hello Martin. I know your point, but it's default encoding issue. User cannot start OpenJDK JDK9/10/11/12 on ja_JP(IBM29626C) and zh_TW(IBM964) locale on AIX. But IBM964 cannot be used for default encoding in current setting. This fix is really required on OpenJDK for AIX. Ichiroh Takiguchi

Re: Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-11-14 Thread Martin Buchholz
Ichiroh, IBM/AIX people should reach consensus on how to handle IBM charsets. I'm going to add some IBM people who might know or care. (I haven't used AIX in 20 years) On Wed, Nov 14, 2018 at 10:23 AM, Ichiroh Takiguchi < taki...@linux.vnet.ibm.com> wrote: > Hello. > > Martin Buchholz

Fwd: Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-11-14 Thread Ichiroh Takiguchi
Hello. Martin Buchholz suggested me via bugs.openjdk.java.net, I should not touch non AIX side. So I rewrote another code. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212794 Change: https://cr.openjdk.java.net/~itakiguchi/8212794/webrev.01/ I don't want

Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-11-08 Thread Volker Simonis
Hi Ichiroh, sorry, but unfortunately, this change is way beyond my level of expertise :) You should try to get a review from Sherman or Alan. Regards, Volker On Fri, Oct 26, 2018 at 3:33 PM Ichiroh Takiguchi wrote: > > Hello. > > Could you review the fix ? > > Bug:

RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

2018-10-26 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212794 Change: https://cr.openjdk.java.net/~itakiguchi/8212794/webrev.00/ I'd like to obtain a sponsor for this issue. IBM964 charset and IBM29626C charset are required for default charset on AIX zh_TW and