Hi Ichiroh,
Looks fine.
I can sponsor that for you. Tomorrow, though, to allow time for any
other comments.
Thanks, Roger
On 12/04/2018 10:21 AM, Ichiroh Takiguchi wrote:
Hello Roger.
Thank you for your suggestion.
Could you review the fix again ?
Bug:
Hello Roger.
Thank you for your suggestion.
Could you review the fix again ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8212794
Change: https://cr.openjdk.java.net/~itakiguchi/8212794/webrev.04/
Thanks,
Ichiroh Takiguchi
On 2018-12-04 23:36, Roger Riggs wrote:
Hi Ichiroh,
On
Hi Ichiroh,
On 12/03/2018 10:30 PM, Ichiroh Takiguchi wrote:
Hello Roger.
Thank you for your suggestion.
src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM33722.java:
I think this is no longer needed since it only has imports.
By the way, the style is to import each specific class
Hello Magnus.
IBM33722 should be in sun.nio.cs.ext package on jdk.charset module
Because it's not used for default encoding on AIX platform.
In case of template file, build tool checks
make/data/charsetmapping/stdcs-aix file for this case.
If class name is there, it will be migrated to
On 2018-12-04 04:30, Ichiroh Takiguchi wrote:
Hello Roger.
Thank you for your suggestion.
src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM33722.java:
I think this is no longer needed since it only has imports.
By the way, the style is to import each specific class and
avoid wild
Hello Roger.
Thank you for your suggestion.
src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM33722.java:
I think this is no longer needed since it only has imports.
By the way, the style is to import each specific class and
avoid wild card imports.
"import sun.nio.cs.*;" is required
Hi Ichiroh,
src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM33722.java:
I think this is no longer needed since it only has imports.
By the way, the style is to import each specific class and avoid
wild card imports.
TestIBMBugs:
- Please use a style consistent with other methods
On 2018-11-30 10:49, Ichiroh Takiguchi wrote:
Hello.
Could you review the fix again ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8212794
Change: https://cr.openjdk.java.net/~itakiguchi/8212794/webrev.02/
I think it looks good but please let someone from core-libs review it too.
Hello.
Could you review the fix again ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8212794
Change: https://cr.openjdk.java.net/~itakiguchi/8212794/webrev.02/
I just fixed only IBM964 for JDK-8212794.
(IBM29626C fix is not included)
On non AIX platform (Linux),
ibm-euctw alias is added
