: core-libs-dev im Auftrag von Alexander
Matveev
Gesendet: Saturday, September 12, 2020 4:22:31 AM
An: core-libs-dev@openjdk.java.net
Betreff: RFR: 8223187: Investigate setLocale() call in jpackage native launcher
setlocale() affects several C functions. We do not use most of these functions
On Sat, 12 Sep 2020 02:15:29 GMT, Alexander Matveev
wrote:
> setlocale() affects several C functions. We do not use most of these
> functions. We only using isspace() and toLower().
> Based on how we use it I do not see any needs for setlocale(). After removing
> it I retested jpackage by
On Sat, 12 Sep 2020 02:15:29 GMT, Alexander Matveev
wrote:
> setlocale() affects several C functions. We do not use most of these
> functions. We only using isspace() and toLower().
> Based on how we use it I do not see any needs for setlocale(). After removing
> it I retested jpackage by
On Sat, 12 Sep 2020 13:00:22 GMT, Kevin Rushforth wrote:
>> Looks good. I confirmed that these are the only two calls to `setlocale` in
>> the jpackage sources.
>
> Note: the title of the JBS bug was updated. Can you update the PR title to
> match?
Looks good to me.
-
PR:
Gesendet: Saturday, September 12, 2020 4:22:31 AM
An: core-libs-dev@openjdk.java.net
Betreff: RFR: 8223187: Investigate setLocale() call in jpackage native launcher
setlocale() affects several C functions. We do not use most of these functions.
We only using isspace() and toLower().
Based on how we use
On Sat, 12 Sep 2020 12:41:50 GMT, Kevin Rushforth wrote:
>> setlocale() affects several C functions. We do not use most of these
>> functions. We only using isspace() and toLower().
>> Based on how we use it I do not see any needs for setlocale(). After
>> removing it I retested jpackage by
On Sat, 12 Sep 2020 02:15:29 GMT, Alexander Matveev
wrote:
> setlocale() affects several C functions. We do not use most of these
> functions. We only using isspace() and toLower().
> Based on how we use it I do not see any needs for setlocale(). After removing
> it I retested jpackage by
setlocale() affects several C functions. We do not use most of these functions.
We only using isspace() and toLower().
Based on how we use it I do not see any needs for setlocale(). After removing
it I retested jpackage by changing
locally on machine and using different language as input
