Re: RFR: 8225061: Performance regression in Regex

2019-05-31 Thread Claes Redestad
Hi Naoto, thanks for reviewing! /Claes On 2019-06-01 02:23, naoto.s...@oracle.com wrote: Hi Claes, Looks good to me. Thanks for catching this on so quickly! Naoto On 5/31/19 5:13 PM, Claes Redestad wrote: Hi, recent Unicode 12.1 updates caused a noticeable regression to Mac OS X build tim

Re: RFR: 8225061: Performance regression in Regex

2019-05-31 Thread naoto . sato
Hi Claes, Looks good to me. Thanks for catching this on so quickly! Naoto On 5/31/19 5:13 PM, Claes Redestad wrote: Hi, recent Unicode 12.1 updates caused a noticeable regression to Mac OS X build times. Quoting Naoto: "The regression was caused by the call to Grapheme.nextBoundary() in NFCC

RFR: 8225061: Performance regression in Regex

2019-05-31 Thread Claes Redestad
Hi, recent Unicode 12.1 updates caused a noticeable regression to Mac OS X build times. Quoting Naoto: "The regression was caused by the call to Grapheme.nextBoundary() in NFCCharProperty.match() method, which got slower with the fix to JDK-8221431 / JDK-8222978 (Unicode 12.1 / Grapheme 12.0 sup