Re: RFR: 8228581: Archive BigInteger constants

2019-08-23 Thread Brian Burkhalter
Hi Claes, > On Aug 23, 2019, at 7:54 AM, Claes Redestad wrote: > > On 2019-08-22 11:47, Alan Bateman wrote: >> On 24/07/2019 14:28, Claes Redestad wrote: >>> Webrev: http://cr.openjdk.java.net/~redestad/8228581/open.00/ >>> >>> >> This lo

Re: RFR: 8228581: Archive BigInteger constants

2019-08-23 Thread Claes Redestad
On 2019-08-22 11:47, Alan Bateman wrote: On 24/07/2019 14:28, Claes Redestad wrote: Webrev: http://cr.openjdk.java.net/~redestad/8228581/open.00/ This looks good to me but I think it would be useful to have Joe or Brian or someone else more steeped in BigInteger to also scan the changes and

Re: RFR: 8228581: Archive BigInteger constants

2019-08-22 Thread Alan Bateman
On 24/07/2019 14:28, Claes Redestad wrote: Hi, BigInteger has a number of pre-calculated constants that are profitable to put up for archiving. This reduces initialization time of BigInteger by 0.3-0.5ms, and archives ~12Kb worth of objects. Bug:    https://bugs.openjdk.java.net/browse/JDK-8228

Re: RFR: 8228581: Archive BigInteger constants

2019-07-24 Thread Claes Redestad
Hi Joe, Jiangli, On 2019-07-24 21:54, Jiangli Zhou wrote: On Wed, Jul 24, 2019 at 12:41 PM Joe Darcy wrote: Hi Claes, For those of us unfamiliar with the archive mechanism, can you describe its semantics or send a pointer to such a description? That's a good point. There are some design do

Re: RFR: 8228581: Archive BigInteger constants

2019-07-24 Thread Jiangli Zhou
On Wed, Jul 24, 2019 at 12:41 PM Joe Darcy wrote: > > Hi Claes, > > For those of us unfamiliar with the archive mechanism, can you describe > its semantics or send a pointer to such a description? That's a good point. There are some design docs describing how Java objects and object graphs archiv

Re: RFR: 8228581: Archive BigInteger constants

2019-07-24 Thread Joe Darcy
Hi Claes, For those of us unfamiliar with the archive mechanism, can you describe its semantics or send a pointer to such a description? Thanks, -Joe On 7/24/2019 6:28 AM, Claes Redestad wrote: Hi, BigInteger has a number of pre-calculated constants that are profitable to put up for archiv

RFR: 8228581: Archive BigInteger constants

2019-07-24 Thread Claes Redestad
Hi, BigInteger has a number of pre-calculated constants that are profitable to put up for archiving. This reduces initialization time of BigInteger by 0.3-0.5ms, and archives ~12Kb worth of objects. Bug:https://bugs.openjdk.java.net/browse/JDK-8228581 Webrev: http://cr.openjdk.java.net/~rede