Re: RFR: 8231640: (prop) Canonical property storage [v13]

2021-09-14 Thread Daniel Fuchs
On Tue, 14 Sep 2021 13:15:18 GMT, Jaikiran Pai wrote: >> I would leave it as an `@implNote` - or possibly `@implSpec`: depending on >> whether or not we want all implementations of the spec to behave in this >> way. However I don't think we would want to prevent subclasses from >> overriding

Re: RFR: 8231640: (prop) Canonical property storage [v13]

2021-09-14 Thread Jaikiran Pai
On Tue, 14 Sep 2021 12:56:28 GMT, Daniel Fuchs wrote: >> Hello Daniel, you are right - I missed discussing whether or not to include >> a `@implNote` to explain the natural sorted order of the property keys. When >> we started this whole PR proposal, Alan had hinted that maybe we should >>

Re: RFR: 8231640: (prop) Canonical property storage [v13]

2021-09-14 Thread Jaikiran Pai
On Tue, 14 Sep 2021 11:43:25 GMT, Magnus Ihse Bursie wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> unused imports > > src/java.base/share/classes/java/util/Properties.java line 828: > >> 826: * a comment

Re: RFR: 8231640: (prop) Canonical property storage [v13]

2021-09-14 Thread Daniel Fuchs
On Tue, 14 Sep 2021 11:59:56 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/java/util/Properties.java line 836: >> >>> 834: * >>> 835: * Then every entry in this {@code Properties} table is >>> 836: * written out, one per line. For each entry the key string is >> >>

Re: RFR: 8231640: (prop) Canonical property storage [v13]

2021-09-14 Thread Jaikiran Pai
On Tue, 14 Sep 2021 02:30:01 GMT, Jaikiran Pai wrote: >> The commit in this PR implements the proposal for enhancement that was >> discussed in the core-libs-dev mailing list recently[1], for >> https://bugs.openjdk.java.net/browse/JDK-8231640 >> >> At a high level - the `store()` APIs in

Re: RFR: 8231640: (prop) Canonical property storage [v13]

2021-09-14 Thread Jaikiran Pai
On Tue, 14 Sep 2021 10:47:34 GMT, Daniel Fuchs wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> unused imports > > src/java.base/share/classes/java/util/Properties.java line 836: > >> 834: * >> 835: *

Re: RFR: 8231640: (prop) Canonical property storage [v13]

2021-09-14 Thread Magnus Ihse Bursie
On Tue, 14 Sep 2021 02:30:01 GMT, Jaikiran Pai wrote: >> The commit in this PR implements the proposal for enhancement that was >> discussed in the core-libs-dev mailing list recently[1], for >> https://bugs.openjdk.java.net/browse/JDK-8231640 >> >> At a high level - the `store()` APIs in

Re: RFR: 8231640: (prop) Canonical property storage [v13]

2021-09-14 Thread Daniel Fuchs
On Tue, 14 Sep 2021 02:30:01 GMT, Jaikiran Pai wrote: >> The commit in this PR implements the proposal for enhancement that was >> discussed in the core-libs-dev mailing list recently[1], for >> https://bugs.openjdk.java.net/browse/JDK-8231640 >> >> At a high level - the `store()` APIs in

Re: RFR: 8231640: (prop) Canonical property storage [v13]

2021-09-13 Thread Jaikiran Pai
> The commit in this PR implements the proposal for enhancement that was > discussed in the core-libs-dev mailing list recently[1], for > https://bugs.openjdk.java.net/browse/JDK-8231640 > > At a high level - the `store()` APIs in `Properties` have been modified to > now look for the