Re: RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument

On 11/11/19 8:53 AM, Henry Jen wrote: Thanks Alan and Mandy for the review. I am guessing the Alan’s preference to use Files.write(aFilePath, lines) is to avoid extra String.join operation, which I would too. The current version with byte[] is more flexible but we most likely won't need it

Re: RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument

:24 AM To: Henry Jen ; Mandy Chung Cc: Mat Carter ; core-libs-dev@openjdk.java.net Subject: Re: RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument On 11/11/2019 16:53, Henry Jen wrote: > Thanks Alan and Mandy for the review. > > I am gues

Re: RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument

On 11/11/2019 16:53, Henry Jen wrote: Thanks Alan and Mandy for the review. I am guessing the Alan’s preference to use Files.write(aFilePath, lines) is to avoid extra String.join operation, which I would too. The current version with byte[] is more flexible but we most likely won't need it in

Re: RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument

s. This is why it now writes out an array of bytes >> >> Cheers >> Mat >> >> >> From: core-libs-dev on behalf of >> Alan Bateman >> Sent: Friday, November 8, 2019 2:56 AM >> To: Henry Jen ; core-libs-dev@openjdk.ja

Re: RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument

-dev on behalf of Alan Bateman Sent: Friday, November 8, 2019 2:56 AM To: Henry Jen ; core-libs-dev@openjdk.java.net Subject: Re: RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument On 07/11/2019 22:55, Henry Jen wrote: Hi, Please review the webrev

Re: RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument

Mat From: core-libs-dev on behalf of Alan Bateman Sent: Friday, November 8, 2019 2:56 AM To: Henry Jen ; core-libs-dev@openjdk.java.net Subject: Re: RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument On 07/11/2019

Re: RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument

On 07/11/2019 22:55, Henry Jen wrote: Hi, Please review the webrev[1], contributed by Mat Carter. You can find the bug details at JBS[2]. I have reviewed and tested the fix, I still need an official review before I can push this. Looks okay although in the test, the createAFile helper method

RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument

Hi, Please review the webrev[1], contributed by Mat Carter. You can find the bug details at JBS[2]. I have reviewed and tested the fix, I still need an official review before I can push this. Cheers, Henry [1] http://cr.openjdk.java.net/~henryjen/jdk/8231863.0/webrev/ [2]