Hi Aleksey,
On 13/01/2020 03:33, Aleksey Shipilev wrote:
Looks fine.
The long/doubleHandle changes probably clash with JDK-8236939.
The test changes probably benefit from cleaner accessors like in JDK-8236920.
But whatever, having any fix in jdk14 that unbreaks 32-bit platforms before
RDP2 h
On 1/9/20 1:01 PM, Maurizio Cimadamore wrote:
> On 09/01/2020 08:10, Nick Gasson wrote:
>> http://cr.openjdk.java.net/~ngasson/8236634/webrev.1/index.html
Looks fine.
The long/doubleHandle changes probably clash with JDK-8236939.
The test changes probably benefit from cleaner accessors like in JD
Looks good - thanks!
Maurizio
On 09/01/2020 08:10, Nick Gasson wrote:
Hi Maurizio,
On 08/01/2020 18:23, Maurizio Cimadamore wrote:
I'm happy to split it into two patches. One with the build/test fixes
for jdk/jdk14 and another with the Unsafe and
internal/foreign/Utils.java change for jdk/jd
Hi Maurizio,
On 08/01/2020 18:23, Maurizio Cimadamore wrote:
I'm happy to split it into two patches. One with the build/test fixes
for jdk/jdk14 and another with the Unsafe and
internal/foreign/Utils.java change for jdk/jdk (or panama/dev?). I
think the most important change for jdk14 is the bu
On 08/01/2020 07:21, Nick Gasson wrote:
Hi Maurizio,
On 07/01/2020 19:06, Maurizio Cimadamore wrote:
As for integrating this - what are your plans? JDK 14 or panama repo? I
see you have targeted 14 in the issue, which is fine, but the priority
is P4. Needs to be at least a P3 to be pushed in
Hi Maurizio,
On 07/01/2020 19:06, Maurizio Cimadamore wrote:
As for integrating this - what are your plans? JDK 14 or panama repo? I
see you have targeted 14 in the issue, which is fine, but the priority
is P4. Needs to be at least a P3 to be pushed in the RDP1 period (and I
think a case can be
Hi Nick,
thanks for the fixes - this generally looks good - the only bit I'm less
sure of is the Unsafe::allocateMemory change. It looks good per se, but
I guess a more targeted fix is also possible (e.g. by checking for size
> Integer.MAX_VALUE in case address size is 4 when we allocate the
n
Hi,
Please review this set of fixes for the new memory access API on 32-bit
Arm/x86.
Bug: https://bugs.openjdk.java.net/browse/JDK-8236634
Webrev: http://cr.openjdk.java.net/~ngasson/8236634/webrev.0/
libNativeAccess.c fails to build with warnings enabled due to casting
pointers to integers o
