; Subject: Re: RFR: 8242039: Improve jlink VersionPropsPlugin
>
>
>
> On 2020-04-03 15:36, Langer, Christoph wrote:
> > Eventually I came up with this result and then I also asked myself the
> question whether the new complexity was worth the benefit. I answered
> myself wit
On 2020-04-03 15:36, Langer, Christoph wrote:
Eventually I came up with this result and then I also asked myself the question
whether the new complexity was worth the benefit. I answered myself with a yes
(though definitely not a clear one ), and that's why I proposed the change.
After
2020/4/3 6:36:53 -0700, christoph.lan...@sap.com:
> 2020/4/2 14:12:54 -0700, mark.reinh...@oracle.com:
>> I thought about doing this when I originally wrote that plugin, but it’s
>> so awkward to achieve with ASM -- as demonstrated by your patch -- that
>> I concluded it wasn’t worth it. Who will
Thanks, Claes.
> -Original Message-
> From: Claes Redestad
> Sent: Donnerstag, 2. April 2020 23:05
> To: Langer, Christoph ; jigsaw-
> d...@openjdk.java.net; core-libs-dev@openjdk.java.net
> Subject: Re: RFR: 8242039: Improve jlink VersionPropsPlugin
>
>
Hi Mark,
> -Original Message-
> From: mark.reinh...@oracle.com
> Sent: Donnerstag, 2. April 2020 23:13
> To: Langer, Christoph
> Cc: jigsaw-...@openjdk.java.net; core-libs-dev@openjdk.java.net
> Subject: Re: RFR: 8242039: Improve jlink VersionPropsPlugin
>
>
2020/4/2 8:01:28 -0700, christoph.lan...@sap.com:
> please review a small improvement for the jlink
> VersionPropsPlugin. The Plugin modifies the bytecode of
> java/lang/VersionProps.class to replace the initializion of certain
> vendor specific system properties with custom values. This
>
On 2020-04-02 20:21, Langer, Christoph wrote:
OK, I created an edition which doesn't change the formatting so that the added
code becomes more obvious:
http://cr.openjdk.java.net/~clanger/webrevs/8242039.1/
Does it look better?
I think so, yes.
/Claes
Hi Claes,
> fun little micro-optimization. :-)
Yep, I got a bit obsessed here. But thanks for the review.
> My only nit is that I'd have preferred if you kept the indentation
> style, since the patch now shifts code around a bit (which makes it
> harder to review and see the history)
OK, I
Hi Christoph,
fun little micro-optimization. :-)
My only nit is that I'd have preferred if you kept the indentation
style, since the patch now shifts code around a bit (which makes it
harder to review and see the history)
/Claes
On 2020-04-02 17:01, Langer, Christoph wrote:
Hi,
please
Hi,
please review a small improvement for the jlink VersionPropsPlugin. The Plugin
modifies the bytecode of java/lang/VersionProps.class to replace the
initializion of certain vendor specific system properties with custom values.
This modification currently adds two bytecodes per constant, a
10 matches
Mail list logo
