On 2020-05-07 23:27, Mikael Vidstedt wrote:
On May 7, 2020, at 7:52 AM, Kumar Srinivasan wrote:
Hi Mikael,
I may have created solinux when the macosx port was merged and in an effort to
reduce the CPP conditionals.
solinux = solaris + linux ie. Vanilla unix code vs Darwin code IIRC has
> On May 7, 2020, at 7:52 AM, Kumar Srinivasan wrote:
>
> Hi Mikael,
>
> I may have created solinux when the macosx port was merged and in an effort
> to reduce the CPP conditionals.
> solinux = solaris + linux ie. Vanilla unix code vs Darwin code IIRC has
> Objective-C, MacOSX specific
> On May 6, 2020, at 11:41 PM, Alan Bateman wrote:
>
> On 07/05/2020 05:56, Mikael Vidstedt wrote:
>> :
>>
>> * File follow-up enhancement for the removal of SO_FLOW_SA and
>> jdk.net.SocketFlow
> I've created JDK-8244582 to track this, we should try to this in the same
> release as JEP
Hi Mikael,
I may have created solinux when the macosx port was merged and in an effort to
reduce the CPP conditionals.
solinux = solaris + linux ie. Vanilla unix code vs Darwin code IIRC has
Objective-C, MacOSX specific thread initialization etc.
I looked over the launcher related code looks
On 07/05/2020 05:56, Mikael Vidstedt wrote:
:
* File follow-up enhancement for the removal of SO_FLOW_SA and
jdk.net.SocketFlow
I've created JDK-8244582 to track this, we should try to this in the
same release as JEP 381.
:
* Get confirmation from Alan that the
New webrev addressing the feedback/comments I have received:
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/corelibs/open/webrev/
incremental:
http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/corelibs.incr/open/webrev/
I hope I caught everything. Some
I have always wondered what “solinux” is supposed to mean - though not enough
to actually ask anybody :)
I’ll file a follow-up enhancement to cover renaming the files.
Thank you for the review!
Cheers,
Mikael
> On May 4, 2020, at 7:59 AM, Roger Riggs wrote:
>
> Hi Michael,
>
> Looks
> On May 5, 2020, at 5:42 AM, Daniel Fuchs wrote:
>
> Hi Mikael,
>
> I spotted another place where a residual reference to Solaris
> remains in a comment:
> src/java.base/unix/native/libnet/PlainSocketImpl.c
>
> 857 #if defined(_AIX)
> 858 if (errno == EINVAL) {
> 859 //
> On May 4, 2020, at 9:27 AM, naoto.s...@oracle.com wrote:
>
> Hi Mikael,
>
> I took a look at i18n related files. It looks good overall.
>
> One nit in java/nio/charset/Charset/DefaultCharsetTest.java: If the test is
> only applicable to linux (@requires os.family == "linux" in jtreg tag
> On May 4, 2020, at 2:33 PM, Brent Christian
> wrote:
>
> Hi,
>
> Looks fine to me. I have just one minor observation:
>
> src/java.base/share/native/libjli/emessages.h
>
> *** 92,102
> #define JRE_ERROR5 "Error: Failed to start a %d-bit JVM process from a
> %d-bit JVM."
> !
Alan, thank you for the review! New webrev coming. Meanwhile comments inline..
> On May 4, 2020, at 1:49 AM, Alan Bateman wrote:
>
> On 04/05/2020 06:12, Mikael Vidstedt wrote:
>> Please review this change which implements part of JEP 381:
>>
>> JBS:
Thank you for reviewing, Max!
Cheers,
Mikael
> On May 4, 2020, at 7:22 AM, Weijun Wang wrote:
>
> There are several security-related files (name.contains("security")) and they
> all look fine.
>
> --Max
>
>
>> On May 4, 2020, at 1:12 PM, Mikael Vidstedt
>> wrote:
>>
>>
>> Please
Hi Mikael,
I spotted another place where a residual reference to Solaris
remains in a comment:
src/java.base/unix/native/libnet/PlainSocketImpl.c
857 #if defined(_AIX)
858 if (errno == EINVAL) {
859 // On Solaris setsockopt will set errno to EINVAL if
the socket
860
Hi,
Looks fine to me. I have just one minor observation:
src/java.base/share/native/libjli/emessages.h
*** 92,102
#define JRE_ERROR5 "Error: Failed to start a %d-bit JVM process
from a %d-bit JVM."
! #define JRE_ERROR6 "Error: Verify all necessary Java SE
components have
Hi Mikael,
I took a look at i18n related files. It looks good overall.
One nit in java/nio/charset/Charset/DefaultCharsetTest.java: If the test
is only applicable to linux (@requires os.family == "linux" in jtreg tag
after the change), the condition isLinux() is no longer needed at line 73.
Hi Michael,
Looks good.
Maybe just a future cleanup to rename files, since the "...so..." is
refering to solaris.
src/java.base/unix/native/libjli/java_md_solinux.h
src/java.base/unix/native/libjli/java_md_solinux.h
Regards, Roger
On 5/4/20 4:49 AM, Alan Bateman wrote:
On 04/05/2020
There are several security-related files (name.contains("security")) and they
all look fine.
--Max
> On May 4, 2020, at 1:12 PM, Mikael Vidstedt
> wrote:
>
>
> Please review this change which implements part of JEP 381:
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8244224
> webrev:
On 04/05/2020 06:12, Mikael Vidstedt wrote:
Please review this change which implements part of JEP 381:
JBS: https://bugs.openjdk.java.net/browse/JDK-8244224
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/corelibs/open/webrev/
JEP:
Please review this change which implements part of JEP 381:
JBS: https://bugs.openjdk.java.net/browse/JDK-8244224
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/corelibs/open/webrev/
JEP: https://bugs.openjdk.java.net/browse/JDK-8241787
Note: When reviewing this, please
19 matches
Mail list logo
