Re: RFR: 8244767 - Potential non-terminated string in getEncodingInternal() on Windows

2020-05-12 Thread Brent Christian
Thanks - change is pushed. -B On 5/11/20 5:26 PM, naoto.s...@oracle.com wrote: +1 Naoto On 5/11/20 5:25 PM, Brian Burkhalter wrote: Hi Brent, It looks OK to me. Brian On May 11, 2020, at 4:36 PM, Brent Christian wrote: Please review this small fix in Windows native code:    Bug: http

Re: RFR: 8244767 - Potential non-terminated string in getEncodingInternal() on Windows

2020-05-11 Thread naoto . sato
+1 Naoto On 5/11/20 5:25 PM, Brian Burkhalter wrote: Hi Brent, It looks OK to me. Brian On May 11, 2020, at 4:36 PM, Brent Christian wrote: Please review this small fix in Windows native code: Bug: https://bugs.openjdk.java.net/browse/JDK-8244767

Re: RFR: 8244767 - Potential non-terminated string in getEncodingInternal() on Windows

2020-05-11 Thread Brian Burkhalter
Hi Brent, It looks OK to me. Brian > On May 11, 2020, at 4:36 PM, Brent Christian > wrote: > > Please review this small fix in Windows native code: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8244767 > > Webrev: http://cr.openjdk.ja

RFR: 8244767 - Potential non-terminated string in getEncodingInternal() on Windows

2020-05-11 Thread Brent Christian
Hi, Please review this small fix in Windows native code: Bug: https://bugs.openjdk.java.net/browse/JDK-8244767 Webrev: http://cr.openjdk.java.net/~bchristi/8244767/webrev-00/ As reported on this thread[1], the getEncodingInternal() function has a potential unterminated string in the case th